Improve policy admin client and related tools#223
Merged
Conversation
ben-grande
force-pushed
the
nonroot-editor
branch
from
6e30f51 to
746fd7e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 78.96% 80.91% +1.94%
==========================================
Files 55 58 +3
Lines 10544 10813 +269
==========================================
+ Hits 8326 8749 +423
+ Misses 2218 2064 -154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
nonroot-editor
branch
14 times, most recently
from
572ddcd to
1dbf790
Compare
ben-grande
added a commit
to ben-grande/qubes-desktop-linux-manager
that referenced
this pull request
Mar 6, 2026
ben-grande
changed the title
ben-grande
force-pushed
the
nonroot-editor
branch
from
1dbf790 to
178e7a1
Compare
marmarek
requested changes
Mar 15, 2026
| rpc = "List" | ||
| return self.call(rpc, is_include=is_include).rstrip("\n").split("\n") | ||
|
|
||
| def policy_include_list(self) -> List[str]: |
Member
There was a problem hiding this comment.
Please keep policy_include_* (as wrappers for new methods) for compatibility. It is a public API after all.
Contributor
Author
There was a problem hiding this comment.
Added them back. I tried to issue a DeprecationWarning, but I am not sure why it not emitted.
PYTHONPATH=. python3import qrexec.policy.admin_client
client = qrexec.policy.admin_client
client.policy_include_list()Warning is not emitted.
Member
|
And also black complains about minor thing |
ben-grande
force-pushed
the
nonroot-editor
branch
2 times, most recently
from
77a5c32 to
12b0b4f
Compare
Contributor
Author
|
PipelineRetryFailed |
marmarek
reviewed
Mar 28, 2026
| else: | ||
| client.policy_replace(name, content, token) | ||
| except subprocess.CalledProcessError as e: | ||
| policy_replace(name, content, token) |
Member
There was a problem hiding this comment.
Rebase failure (should be between try/except)? You do fix it in a later commit (0b26e0a)
Contributor
Author
There was a problem hiding this comment.
Yes, messed up rebase.
ben-grande
force-pushed
the
nonroot-editor
branch
from
12b0b4f to
a217b14
Compare
Member
|
https://gitlab.com/QubesOS/qubes-core-qrexec/-/jobs/13694697611
Bug in |
Contributor
Author
Attempting to address this in #228. |
ben-grande
force-pushed
the
nonroot-editor
branch
2 times, most recently
from
1d1972f to
1c8e634
Compare
marmarek
added a commit
to QubesOS/qubes-desktop-linux-manager
that referenced
this pull request
Apr 29, 2026
* origin/pr/301: Use new policy admin exceptions Pull request description: For: QubesOS/qubes-issues#10746 Requires: QubesOS/qubes-core-qrexec#223
ben-grande
force-pushed
the
nonroot-editor
branch
from
1c8e634 to
1bfe03d
Compare
Largely duplicate of the server side methods, but creating it anyway as it serves two purposes: - If the client can receive appropriate exceptions - If the client methods works
The repository is already reformatted with black using that same line length.
ben-grande
force-pushed
the
nonroot-editor
branch
3 times, most recently
from
b9b6b0f to
be28027
Compare
Easier to move test files around.
Easier to identify which test file relates to which file when they are under the same directory structure.
ben-grande
force-pushed
the
nonroot-editor
branch
from
be28027 to
842a543
Compare
Contributor
Author
|
PipelineRetryFailed |
This was referenced May 5, 2026
Merged
marmarek
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--to shell commands.policyextension so editors can recognize the filetype and load syntax accordinglyAnd many more things as commit grew. Check each commit message.
Fixes: QubesOS/qubes-issues#10745
Fixes: QubesOS/qubes-issues#10746