qvm-appmenus: remove unstable-format gate for --get-available by Jayant-kernel · Pull Request #72 · QubesOS/qubes-desktop-linux-common

Jayant-kernel · 2026-03-03T04:05:02Z

Summary

Remove the runtime requirement for --i-understand-format-is-unstable when using qvm-appmenus --get-available.

This makes --get-available work directly, as requested in QubesOS/qubes-issues#10595.

What changed

qubesappmenus/__init__.py
- Removed the args.fool gate and kitten error for --get-available.
- Kept --i-understand-format-is-unstable as a backward-compatible no-op.
doc/tools/qvm-appmenus.rst
- Updated --get-available docs to remove unstable/required-flag wording.
- Removed unstable-format note from --file-field docs.
qubesappmenus/tests.py
- Added unit test test_132_get_available_does_not_require_unstable_flag.

Why

Issue discussion confirms this output format should now be considered stable and no extra pledge flag is needed.

Validation

Added focused unit test for the changed CLI behavior.
Could not run tests in this environment because dependency xdg is missing (ModuleNotFoundError: No module named 'xdg').

AI usage disclosure

This change was prepared with AI assistance and manually reviewed before submission.

Closes QubesOS/qubes-issues#10595.

Jayant-kernel · 2026-03-03T04:05:12Z

Pushed the small fix for #10595.

When you have a moment, could you please take a look? Happy to adjust anything needed.

codecov · 2026-03-03T05:26:20Z

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.73%. Comparing base (3667bff) to head (e4cb94a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
qubesappmenus/__init__.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   62.07%   65.73%   +3.66%     
==========================================
  Files           2        2              
  Lines         683      683              
==========================================
+ Hits          424      449      +25     
+ Misses        259      234      -25

Flag	Coverage Δ
unittests	`65.73% <50.00%> (+3.66%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ben-grande · 2026-03-04T09:33:30Z

Please squash the commits.

ben-grande · 2026-03-04T09:34:58Z

    '--i-understand-format-is-unstable', dest='fool',
    action='store_true',
-    help='required pledge for --get-available')
+    help='deprecated no-op for backward compatibility')


Please use "deprecated" option: https://docs.python.org/3/library/argparse.html#deprecated. This is only available in python3.13 and therefore cannot be backported to R4.2.

ben-grande · 2026-03-04T09:39:09Z

+        app = TestApp()
+        app.domains = {vm.name: vm}
+
+        parse_args.return_value = types.SimpleNamespace(


Are all of the options below necessary to be specified explicitly? Seems a bit verbose.

Jayant-kernel · 2026-03-05T14:56:10Z

@ben-grande
Rereview the changes

ben-grande · 2026-03-06T14:24:32Z

Please check the changes you pushed. They haven't addressed my concerns. Clicking on the lastest compare shows no changes: https://github.com/QubesOS/qubes-desktop-linux-common/compare/d1fb07e895b2a6c6c1e9a1fdc5eee333ca617e31..60050d4afd05d7f159916380461233218f922778

Jayant-kernel · 2026-03-06T16:19:32Z

Hi @ben-grande,
addressed both points and added a manual stderr warning for the deprecated flag (since deprecated= needs Python 3.13), and simplified the test to call main() directly with real CLI args instead of the verbose mock.
Are the changes okay

ben-grande · 2026-03-09T11:37:17Z

dded a manual stderr warning for the deprecated flag (since deprecated= needs Python 3.13)

I think that only Fedora GUIVM is supported (last time I tried to use debian, a lot of things were broken). Only debian-12 doesn't have python3.13. As I think that will break tests, will leave as is.

--get-available no longer requires --i-understand-format-is-unstable. The flag is kept as a deprecated no-op for backward compatibility and prints a warning to stderr when used. Fixes QubesOS/qubes-issues#10595

qubesos-bot · 2026-03-09T18:44:05Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026031319-4.3-debian&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update

Failed tests

No failures!

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/166096#dependencies
Nothing fixed

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

13 tests

debian-13-xfce_dom0-dispvm-api (mean:6.539): 78.47 🟢 ( previous job: 79.83, improvement: 98.29%)
debian-13-xfce_dom0-dispvm-gui-api (mean:7.827): 93.92 🔻 ( previous job: 92.49, degradation: 101.55%)
debian-13-xfce_dom0-dispvm-preload-2-api (mean:3.149): 37.79 🟢 ( previous job: 44.94, improvement: 84.08%)
debian-13-xfce_dom0-dispvm-preload-2-delay-0-api (mean:2.917): 35.00 🟢 ( previous job: 41.46, improvement: 84.42%)
debian-13-xfce_dom0-dispvm-preload-2-delay-minus-1d2-api (mean:3.307): 39.69 🟢 ( previous job: 47.01, improvement: 84.43%)
debian-13-xfce_dom0-dispvm-preload-4-api (mean:2.284): 27.41 🟢 ( previous job: 37.67, improvement: 72.75%)
debian-13-xfce_dom0-dispvm-preload-4-delay-0-api (mean:2.809): 33.71 🟢 ( previous job: 36.76, improvement: 91.71%)
debian-13-xfce_dom0-dispvm-preload-4-delay-minus-1d2-api (mean:2.441): 29.29 🟢 ( previous job: 37.87, improvement: 77.36%)
debian-13-xfce_dom0-dispvm-preload-2-gui-api (mean:4.989): 59.87 🔻 ( previous job: 55.58, degradation: 107.71%)
debian-13-xfce_dom0-dispvm-preload-4-gui-api (mean:4.135): 49.62 🔻 ( previous job: 47.73, degradation: 103.97%)
debian-13-xfce_dom0-dispvm-preload-6-gui-api (mean:4.198): 50.38 🔻 ( previous job: 47.11, degradation: 106.93%)
debian-13-xfce_dom0-vm-api (mean:0.038): 0.45 🔻 ( previous job: 0.41, degradation: 109.93%)
debian-13-xfce_dom0-vm-gui-api (mean:0.039): 0.47 🟢 ( previous job: 0.48, improvement: 96.67%)

ben-grande · 2026-03-10T06:48:52Z

system_tests_extra

* TC_00_Appmenus: [test_132_get_available_does_not_require_unstable_flag](https://openqa.qubes-os.org/tests/169502#step/TC_00_Appmenus/17) (error)
  `~~~~~~~~~^^^^^^^^... SystemExit: 2`

https://openqa.qubes-os.org/tests/169502#step/TC_00_Appmenus/17

The integration test runs as root. Apparently, other tests don't have to deal with that because they are not invoking calling main(). I think it is okay to use --force-root in this case.

Jayant-kernel · 2026-03-12T05:05:09Z

Addressed the OpenQA failure in TC_00_Appmenus.test_132_get_available_does_not_require_unstable_flag.

couse bec of this test invokes qvm-appmenus.main() directly, and OpenQA integration runs as root. Without --force-root, argparse exits with SystemExit: 2.

Fix in commit e4cb94a:

Updated test invocation to include --force-root:
- qubesappmenus.main(['--force-root', '--get-available', vm.name], app=self.app)

This keeps behavior unchanged for users and only makes the integration test valid under root-run environment.

marmarek · 2026-03-13T16:02:07Z

PipelineRetry

marmarek · 2026-03-14T13:41:25Z

This one is okay, now please remove usage of this option from qubes-manager and qubes-desktop-linux-manager repositories.

* origin/pr/446: appmenu_select: remove --i-understand-format-is-unstable flag Pull request description: The `--i-understand-format-is-unstable` flag is no longer needed after QubesOS/qubes-desktop-linux-common#72 removed the unstable-format gate for `--get-available`. Remove the now-redundant flag from the command invocation.

Jayant-kernel mentioned this pull request Mar 3, 2026

Remove the need to sacrifice a cute kitten (and to understand-that-format-is-unstable) with qvm-appmenus QubesOS/qubes-issues#10595

Closed

ben-grande reviewed Mar 4, 2026

View reviewed changes

Jayant-kernel force-pushed the feat-qvm-appmenus-no-kitten-10595 branch from d1fb07e to 60050d4 Compare March 5, 2026 14:55

Jayant-kernel requested a review from ben-grande March 5, 2026 14:56

ben-grande added the openqa-group-2 label Mar 9, 2026

qvm-appmenus: drop unstable-format pledge for get-available

09e903e

--get-available no longer requires --i-understand-format-is-unstable. The flag is kept as a deprecated no-op for backward compatibility and prints a warning to stderr when used. Fixes QubesOS/qubes-issues#10595

Jayant-kernel force-pushed the feat-qvm-appmenus-no-kitten-10595 branch from a72817a to 09e903e Compare March 9, 2026 18:29

This was referenced Mar 9, 2026

splitgpg2: allow xauthority OPTION for Flatpak clients QubesOS/qubes-app-linux-split-gpg2#33

Merged

Introduce audio-volume feature QubesOS/qubes-core-admin-client#405

Open

tests: allow get-available CLI test to run as root

e4cb94a

qubesos-bot mentioned this pull request Mar 13, 2026

Don't hang is-system-running when GUI is disabled QubesOS/qubes-gui-agent-linux#255

Merged

marmarek approved these changes Mar 14, 2026

View reviewed changes

marmarek merged commit 75c9924 into QubesOS:main Mar 14, 2026
3 of 5 checks passed

Jayant-kernel mentioned this pull request Mar 16, 2026

appmenu_select: remove --i-understand-format-is-unstable flag QubesOS/qubes-manager#446

Merged

Conversation

Jayant-kernel commented Mar 3, 2026

Summary

What changed

Why

Validation

AI usage disclosure

Uh oh!

Jayant-kernel commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ben-grande commented Mar 4, 2026

Uh oh!

ben-grande Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ben-grande Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Jayant-kernel commented Mar 5, 2026

Uh oh!

ben-grande commented Mar 6, 2026

Uh oh!

Jayant-kernel commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ben-grande commented Mar 9, 2026

Uh oh!

qubesos-bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

ben-grande commented Mar 10, 2026

Uh oh!

Jayant-kernel commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marmarek commented Mar 13, 2026

Uh oh!

marmarek commented Mar 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jayant-kernel commented Mar 3, 2026 •

edited

Loading

codecov Bot commented Mar 3, 2026 •

edited

Loading

Jayant-kernel commented Mar 6, 2026 •

edited

Loading

qubesos-bot commented Mar 9, 2026 •

edited

Loading

Jayant-kernel commented Mar 12, 2026 •

edited

Loading