Hide internal qubes

For: QubesOS/qubes-issues#1512

Author: ben-grande

qubes_config/global_config/basics_handler.py

@@ -740,19 +740,27 @@ def __init__(self, gtk_builder: Gtk.Builder, qapp: qubesadmin.Qubes):
 
     @staticmethod
     def _clock_vm_filter(vm) -> bool:
-        return vm.klass != "TemplateVM"
+        return (
+            vm.klass != "TemplateVM"
+            and not getattr(vm, "template_for_dispvms", False)
+            and not get_boolean_feature(vm, "internal")
+        )
 
     @staticmethod
     def _default_template_filter(vm) -> bool:
-        return vm.klass == "TemplateVM"
+        return vm.klass == "TemplateVM" and not get_boolean_feature(vm, "internal")
 
     @staticmethod
     def _default_netvm_filter(vm) -> bool:
-        return getattr(vm, "provides_network", False)
+        return getattr(vm, "provides_network", False) and not get_boolean_feature(
+            vm, "internal"
+        )
 
     @staticmethod
     def _default_dispvm_filter(vm) -> bool:
-        return getattr(vm, "template_for_dispvms", False)
+        return getattr(vm, "template_for_dispvms", False) and not get_boolean_feature(
+            vm, "internal"
+        )
 
     def save(self):
         for handler in self.handlers:

qubes_config/global_config/device_attachments.py

@@ -33,6 +33,7 @@
 
 from ..widgets.gtk_widgets import TokenName
 from ..widgets.gtk_utils import show_error
+from ..widgets.utils import get_boolean_feature
 from .device_widgets import (
     DevPolicyRow,
     DevPolicyDialogHandler,
@@ -122,7 +123,9 @@ def __init__(
             self.qapp,
             "edit_device",
             [],
-            filter_function=lambda vm: vm.klass != "AdminVM",
+            filter_function=lambda vm: vm.klass != "AdminVM"
+            and not getattr(vm, "template_for_dispvms", False)
+            and not get_boolean_feature(vm, "internal"),
         )
 
         self.backend_vm: Optional[qubesadmin.vm.QubesVM] = None
@@ -398,7 +401,9 @@ def __init__(
             self.qapp,
             "required_device",
             [],
-            filter_function=lambda vm: vm.klass != "AdminVM",
+            filter_function=lambda vm: vm.klass != "AdminVM"
+            and not getattr(vm, "template_for_dispvms", False)
+            and not get_boolean_feature(vm, "internal"),
         )
 
         self.dev_modeler = self.fill_combo_with_devices(

qubes_config/global_config/device_blocks.py

@@ -23,6 +23,7 @@
 from qubesadmin.device_protocol import DeviceCategory, DeviceInterface
 
 from ..widgets.gtk_widgets import TokenName, VMListModeler
+from ..widgets.utils import get_feature
 from .device_widgets import (
     DevPolicyDialogHandler,
     DevPolicyRow,
@@ -57,7 +58,8 @@ def __init__(self, builder: Gtk.Builder, qapp, parent_window: Gtk.Window):
         self.qube_model = VMListModeler(
             combobox=self.qube_combo,
             qapp=self.qapp,
-            filter_function=lambda vm: vm.klass != "AdminVM",
+            filter_function=lambda vm: vm.klass != "AdminVM"
+            and not get_feature(vm, "internal"),
             current_value=None,
         )
         self.qube_model.connect_change_callback(self._qube_selected)

qubes_config/global_config/rule_list_widgets.py

@@ -27,7 +27,7 @@
     TokenName,
 )
 from ..widgets.gtk_utils import show_error, ask_question
-from ..widgets.utils import BiDictionary
+from ..widgets.utils import get_boolean_feature, BiDictionary
 from .policy_rules import AbstractRuleWrapper, AbstractVerbDescription
 
 import gi
@@ -106,7 +106,9 @@ def __init__(
         self.qapp = qapp
         self.selected_value = initial_value
         self.filter_function = (
-            filter_function if filter_function else lambda x: str(x) != "dom0"
+            filter_function
+            if filter_function
+            else lambda x: str(x) != "dom0" and not get_boolean_feature(x, "internal")
         )
 
         self.combobox: Gtk.ComboBox = Gtk.ComboBox.new_with_entry()
@@ -686,7 +688,9 @@ def __init__(
 
     @staticmethod
     def _dvm_template_filter(vm: qubesadmin.vm.QubesVM):
-        return getattr(vm, "template_for_dispvms", False)
+        return getattr(vm, "template_for_dispvms", False) and not get_boolean_feature(
+            vm, "internal"
+        )
 
     def _hide_target_on_deny(self):
         if self.action_widget.get_selected() == "deny":

qubes_config/global_config/updates_handler.py

@@ -450,11 +450,17 @@ def _check_for_whonix(self) -> bool:
 
     @staticmethod
     def _updatevm_filter(vm):
-        return getattr(vm, "provides_network", False)
+        return getattr(vm, "provides_network", False) and not get_boolean_feature(
+            vm, "internal"
+        )
 
     @staticmethod
     def _whonixupdatevm_filter(vm):
-        return "anon-gateway" in vm.tags
+        return (
+            "anon-gateway" in vm.tags
+            and vm.klass != "TemplateVM"
+            and not get_boolean_feature(vm, "internal")
+        )
 
     @staticmethod
     def _rule_filter(rule):
@@ -466,6 +472,8 @@ def _rule_filter(rule):
 
     @staticmethod
     def _needs_updatevm_filter(vm):
+        if get_boolean_feature(vm, "internal"):
+            return False
         if vm.klass in ("AdminVM", "AppVM"):
             return False
         if vm.klass == "StandaloneVM":
@@ -683,6 +691,8 @@ def __init__(
                 lambda vm: vm.klass != "TemplateVM"
                 and vm.klass != "AdminVM"
                 and vm.is_networked()
+                and not getattr(vm, "template_for_dispvms", False)
+                and not get_boolean_feature(vm, "internal")
             ),
             current_value=self.qapp.updatevm,
             additional_options=NONE_CATEGORY,

qubes_config/global_config/usb_devices.py

@@ -465,6 +465,8 @@ def load_rules_for_usb_qube(self):
         self.error_handler.clear_all_errors()
 
         for vm in self.qapp.domains:
+            if get_feature(vm, "internal"):
+                continue
             if vm.features.check_with_template(self.SUPPORTED_SERVICE_FEATURE):
                 if vm == usb_qube:
                     continue

qubes_config/new_qube/template_handler.py

@@ -28,6 +28,7 @@
 import qubesadmin.vm
 from ..widgets.gtk_widgets import VMListModeler
 from ..widgets.gtk_utils import show_error
+from ..widgets.utils import get_boolean_feature
 from .application_selector import ApplicationData
 
 import gi
@@ -261,28 +262,32 @@ def __init__(self, gtk_builder: Gtk.Builder, qapp: qubesadmin.Qubes):
                 gtk_builder=gtk_builder,
                 qapp=self.qapp,
                 name_suffix="app",
-                filter_function=lambda x: x.klass == "TemplateVM",
+                filter_function=lambda x: x.klass == "TemplateVM"
+                and not get_boolean_feature(x, "internal"),
                 default_value=self.qapp.default_template,
             ),
             "qube_type_template": TemplateSelectorNoneCombo(
                 gtk_builder=gtk_builder,
                 qapp=self.qapp,
                 name_suffix="template",
-                filter_function=lambda x: x.klass == "TemplateVM",
+                filter_function=lambda x: x.klass == "TemplateVM"
+                and not get_boolean_feature(x, "internal"),
                 default_value=None,
             ),
             "qube_type_standalone": TemplateSelectorNoneCombo(
                 gtk_builder=gtk_builder,
                 qapp=self.qapp,
                 name_suffix="standalone",
-                filter_function=lambda x: x.klass in ("TemplateVM", "StandaloneVM"),
+                filter_function=lambda x: x.klass in ("TemplateVM", "StandaloneVM")
+                and not get_boolean_feature(x, "internal"),
                 default_value=None,
             ),
             "qube_type_disposable": TemplateSelectorCombo(
                 gtk_builder=gtk_builder,
                 qapp=self.qapp,
                 name_suffix="dispvm",
-                filter_function=lambda x: getattr(x, "template_for_dispvms", False),
+                filter_function=lambda x: getattr(x, "template_for_dispvms", False)
+                and not get_boolean_feature(x, "internal"),
                 default_value=self.qapp.default_dispvm,
             ),
         }