Merge remote-tracking branch 'origin/pr/258' into pr-264-merge

* origin/pr/258:
  Last round of review fixes
  Fix updater tests for new mocks
  pacify black
  Review fixes
  Add config for device attachments to Global Config
  Change global config tests to use Mock Qubes API
  Changed VM flowbox for improved UX

Pull request description:

- improved dark mode
- use Mock API for tests
- add config for device attachments to Global Config, in particular
- devices denied can be configured
- auto-attach, ask-to-attach and required auto-attach can be configured

requires QubesOS/qubes-core-admin-client#355

Author: marmarek

.gitlab-ci.yml

@@ -46,3 +46,4 @@ checks:black:
   variables:
     DIR: .
     SKIP_PYLINT: 1
+    BLACK_ARGS: -l88 -v --diff --color --check

.pylintrc

@@ -91,7 +91,7 @@ notes=FIXME,FIX,XXX,TODO
 [FORMAT]
 
 # Maximum number of characters on a single line.
-max-line-length=80
+max-line-length=88
 
 # Maximum number of lines in a module
 max-module-lines=3000

icons/scalable/devices-dark.svg

@@ -331,9 +331,7 @@ def save_values(self, values_dict: Dict[str, int]):
         """Wants a dict of 'vm-min-mem': value in MiB and
         'dom0-mem-boost': value in MiB"""
         # qmemman settings
-        text_dict = {
-            key: str(int(value)) + "MiB" for key, value in values_dict.items()
-        }
+        text_dict = {key: str(int(value)) + "MiB" for key, value in values_dict.items()}
 
         assert (
             len(text_dict) == 2
@@ -502,9 +500,7 @@ def __init__(self, qapp: qubesadmin.Qubes, widget: Gtk.ComboBoxText):
         )
 
     def _get_kernel_options(self) -> Dict[str, str]:
-        kernels = [
-            kernel.vid for kernel in self.qapp.pools["linux-kernel"].volumes
-        ]
+        kernels = [kernel.vid for kernel in self.qapp.pools["linux-kernel"].volumes]
         kernels = sorted(kernels, key=KernelVersion)
         kernels_dict = {kernel: kernel for kernel in kernels}
         kernels_dict["(none)"] = None
@@ -666,9 +662,7 @@ def __init__(self, gtk_builder: Gtk.Builder, qapp: qubesadmin.Qubes):
                 is_bool=False,
             )
         )
-        self.handlers.append(
-            KernelHolder(qapp=self.qapp, widget=self.kernel_combo)
-        )
+        self.handlers.append(KernelHolder(qapp=self.qapp, widget=self.kernel_combo))
 
         self.handlers.append(MemoryHandler(gtk_builder))