Global clipboard clearing option#225
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 93.01% 92.98% -0.04%
==========================================
Files 64 64
Lines 13277 13277
==========================================
- Hits 12350 12346 -4
- Misses 927 931 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I like this, there is one problem: what if the widget crashes / someone is using a desktop environment that has problems with the widget, but the person relying on global clipboard will not know that the clearing stopped working (because copy-paste itself will work, just the notifications won't...). @marmarek mentioned that maybe this should happen in the gui daemon for that reason. |
Well said. I believe the manual clearing in systray applet menu could still remain since it is useful. The The above should just generate a visual notification via widget. And gui-daemon could check the existing metadata on timeout to assure global clipboard still belongs to that specific vm and that particular copy action. We just need another config/command line option for |
e429bb4 to
09edbde
Compare
Menu item to Global Clipboard widget to allow users to manually clear it related: QubesOS/qubes-issues#6641
09edbde to
942b24b
Compare
|
@marmarta as per discussion on Matrix, this PR is amended to only provide Global Clipboard clearing function via Qui Clipboard menu. I appreciate if you could review. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025102219-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 84 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:17 performance degradations
Remaining performance tests:163 tests
|
Menu item to Global Clipboard widget to allow users to manually clear it.
related: QubesOS/qubes-issues#6641