Fix `prohibit-start` selection & tooltip by alimirjamali · Pull Request #253 · QubesOS/qubes-desktop-linux-manager

alimirjamali · 2025-03-17T17:27:20Z

No description provided.

codecov · 2025-03-17T17:53:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (2395c89) to head (a474c64).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   93.25%   92.67%   -0.59%     
==========================================
  Files          58       59       +1     
  Lines       11140    11264     +124     
==========================================
+ Hits        10389    10439      +50     
- Misses        751      825      +74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2025-03-19T09:21:23Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025032406-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

system_tests_extra
- TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
system_tests_network_updates
- VmUpdates_fedora-41-xfce: test_110_update_via_proxy_qubes_vm_update (failure)
  AssertionError: 1 not found in (0,) : rpm -q test-pkg | grep 1.1: b''
- VmUpdates_fedora-41-xfce: test_130_no_network_qubes_vm_update (failure)
  AssertionError: qubes-vm-update return unexpected code: 0 in (23,)
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_223_audio_play_hvm (failure)
  AssertionError: only silence detected, no useful audio data
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Explorer-empt...
system_tests_qwt_win11@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/dcWzE-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-gateway-17-pool: test_300_bug_1028_gui_memory_pinning (failure)
  AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_basic_vm_qrexec_gui_xfs
- TC_20_NonAudio_whonix-gateway-17-pool: test_300_bug_1028_gui_memory_pinning (failure)
  AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_suspend@hw1
- suspend: wait_serial (wait serial expected)
  # wait_serial expected: qr/p5~T5-\d+-/...
- suspend: Failed (test died + timed out)
  # Test died: command 'true' timed out at /usr/lib/os-autoinst/autot...

Failed tests

14 failures

system_tests_extra
- TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
system_tests_network_updates
- VmUpdates_fedora-41-xfce: test_110_update_via_proxy_qubes_vm_update (failure)
  AssertionError: 1 not found in (0,) : rpm -q test-pkg | grep 1.1: b''
- VmUpdates_fedora-41-xfce: test_130_no_network_qubes_vm_update (failure)
  AssertionError: qubes-vm-update return unexpected code: 0 in (23,)
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_223_audio_play_hvm (failure)
  AssertionError: only silence detected, no useful audio data
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Explorer-empt...
system_tests_qwt_win11@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/dcWzE-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_basic_vm_qrexec_gui_ext4
- TC_20_NonAudio_whonix-gateway-17-pool: test_300_bug_1028_gui_memory_pinning (failure)
  AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_basic_vm_qrexec_gui_xfs
- TC_20_NonAudio_whonix-gateway-17-pool: test_300_bug_1028_gui_memory_pinning (failure)
  AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_suspend@hw1
- suspend: wait_serial (wait serial expected)
  # wait_serial expected: qr/p5~T5-\d+-/...
- suspend: Failed (test died + timed out)
  # Test died: command 'true' timed out at /usr/lib/os-autoinst/autot...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

14 fixed

system_tests_suspend
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_basic_vm_qrexec_gui
- TC_20_NonAudio_whonix-gateway-17: test_300_bug_1028_gui_memory_pinning (failure)
  AssertionError: Dom0 window doesn't match VM window content, saved ...
system_tests_qrexec
- TC_00_Qrexec_fedora-41-xfce: test_081_qrexec_service_argument_allow_specific (error)
  subprocess.CalledProcessError: Command '/usr/lib/qubes/qrexec-clien...
system_tests_kde_gui_interactive
- clipboard_and_web: unnamed test (unknown)
- clipboard_and_web: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-website' matche...
- clipboard_and_web: wait_serial (wait serial expected)
  # wait_serial expected: "lspci; echo 2E8vz-\$?-"...
system_tests_guivm_vnc_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'files-work' matched...
system_tests_audio
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
system_tests_whonix@hw7
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)

Unstable tests

Details

Performance Tests

Performance degradation:

17 performance degradations

whonix-gateway-17_exec: 7.82 :small_red_triangle_up: ( previous job: 6.82, degradation: 114.66%)
whonix-gateway-17_socket: 8.93 :small_red_triangle_up: ( previous job: 7.24, degradation: 123.43%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 98442.00 :small_red_triangle_up: ( previous job: 129298.00, degradation: 76.14%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 118893.00 :small_red_triangle_up: ( previous job: 294295.00, degradation: 40.40%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 12438.00 :small_red_triangle_up: ( previous job: 95454.00, degradation: 13.03%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 21883.00 :small_red_triangle_up: ( previous job: 79803.00, degradation: 27.42%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8570.00 :small_red_triangle_up: ( previous job: 10795.00, degradation: 79.39%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 142323.00 :small_red_triangle_up: ( previous job: 250795.00, degradation: 56.75%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 156768.00 :small_red_triangle_up: ( previous job: 184752.00, degradation: 84.85%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4090.00 :small_red_triangle_up: ( previous job: 4903.00, degradation: 83.42%)
fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 96147.00 :small_red_triangle_up: ( previous job: 162081.00, degradation: 59.32%)
fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 64000.00 :small_red_triangle_up: ( previous job: 87940.00, degradation: 72.78%)
fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2097.00 :small_red_triangle_up: ( previous job: 3599.00, degradation: 58.27%)
fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 137891.00 :small_red_triangle_up: ( previous job: 170062.00, degradation: 81.08%)
fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 292898.00 :small_red_triangle_up: ( previous job: 334687.00, degradation: 87.51%)
fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 285949.00 :small_red_triangle_up: ( previous job: 324737.00, degradation: 88.06%)
fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2327.00 :small_red_triangle_up: ( previous job: 5672.00, degradation: 41.03%)

Remaining performance tests:

55 tests

debian-12-xfce_exec: 7.33 :small_red_triangle_up: ( previous job: 7.12, degradation: 102.98%)
debian-12-xfce_exec-root: 28.63 🟢 ( previous job: 28.65, improvement: 99.91%)
debian-12-xfce_socket: 8.18 🟢 ( previous job: 8.60, improvement: 95.06%)
debian-12-xfce_socket-root: 9.02 :small_red_triangle_up: ( previous job: 8.52, degradation: 105.81%)
debian-12-xfce_exec-data-simplex: 67.78 🟢 ( previous job: 71.62, improvement: 94.64%)
debian-12-xfce_exec-data-duplex: 66.41 🟢 ( previous job: 70.34, improvement: 94.41%)
debian-12-xfce_exec-data-duplex-root: 83.96 :small_red_triangle_up: ( previous job: 82.72, degradation: 101.50%)
debian-12-xfce_socket-data-duplex: 163.00 :small_red_triangle_up: ( previous job: 156.96, degradation: 103.85%)
fedora-41-xfce_exec: 9.41 :small_red_triangle_up: ( previous job: 9.27, degradation: 101.49%)
fedora-41-xfce_exec-root: 61.93 :small_red_triangle_up: ( previous job: 61.51, degradation: 100.68%)
fedora-41-xfce_socket: 8.49 🟢 ( previous job: 8.63, improvement: 98.42%)
fedora-41-xfce_socket-root: 8.70 🟢 ( previous job: 8.71, improvement: 99.96%)
fedora-41-xfce_exec-data-simplex: 71.65 🟢 ( previous job: 75.53, improvement: 94.86%)
fedora-41-xfce_exec-data-duplex: 69.76 🟢 ( previous job: 71.56, improvement: 97.48%)
fedora-41-xfce_exec-data-duplex-root: 105.45 🟢 ( previous job: 109.13, improvement: 96.63%)
fedora-41-xfce_socket-data-duplex: 149.85 🟢 ( previous job: 150.61, improvement: 99.50%)
whonix-gateway-17_exec-root: 40.02 🟢 ( previous job: 40.43, improvement: 98.98%)
whonix-gateway-17_socket-root: 7.92 :small_red_triangle_up: ( previous job: 7.65, degradation: 103.53%)
whonix-gateway-17_exec-data-simplex: 72.80 🟢 ( previous job: 78.32, improvement: 92.95%)
whonix-gateway-17_exec-data-duplex: 75.22 🟢 ( previous job: 76.65, improvement: 98.13%)
whonix-gateway-17_exec-data-duplex-root: 96.28 :small_red_triangle_up: ( previous job: 88.52, degradation: 108.77%)
whonix-gateway-17_socket-data-duplex: 151.21 🟢 ( previous job: 171.76, improvement: 88.03%)
whonix-workstation-17_exec: 8.06 :small_red_triangle_up: ( previous job: 7.67, degradation: 105.09%)
whonix-workstation-17_exec-root: 57.60 🟢 ( previous job: 58.26, improvement: 98.86%)
whonix-workstation-17_socket: 8.14 🟢 ( previous job: 8.19, improvement: 99.31%)
whonix-workstation-17_socket-root: 8.12 🟢 ( previous job: 8.13, improvement: 99.84%)
whonix-workstation-17_exec-data-simplex: 71.34 🟢 ( previous job: 74.99, improvement: 95.12%)
whonix-workstation-17_exec-data-duplex: 63.84 🟢 ( previous job: 72.71, improvement: 87.80%)
whonix-workstation-17_exec-data-duplex-root: 86.39 🟢 ( previous job: 99.82, improvement: 86.54%)
whonix-workstation-17_socket-data-duplex: 167.60 🟢 ( previous job: 169.50, improvement: 98.88%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 408960.00 :small_red_triangle_up: ( previous job: 446963.00, degradation: 91.50%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5995.00 :small_red_triangle_up: ( previous job: 6149.00, degradation: 97.50%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4931.00 :green_circle: ( previous job: 4826.00, improvement: 102.18%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 450032.00 :green_circle: ( previous job: 382273.00, improvement: 117.73%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 430449.00 :small_red_triangle_up: ( previous job: 437636.00, degradation: 98.36%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103640.00 :green_circle: ( previous job: 62195.00, improvement: 166.64%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7785.00 :green_circle: ( previous job: 6479.00, improvement: 120.16%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7868.00 :green_circle: ( previous job: 7669.00, improvement: 102.59%)
fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 399153.00 :green_circle: ( previous job: 368309.00, improvement: 108.37%)
fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 351399.00 :green_circle: ( previous job: 318716.00, improvement: 110.25%)
fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 83724.00 :green_circle: ( previous job: 82694.00, improvement: 101.25%)
fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8015.00 :small_red_triangle_up: ( previous job: 8485.00, degradation: 94.46%)
fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1302.00 :green_circle: ( previous job: 542.00, improvement: 240.22%)
fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 359101.00 :small_red_triangle_up: ( previous job: 373957.00, degradation: 96.03%)
fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 90100.00 :green_circle: ( previous job: 61534.00, improvement: 146.42%)
fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 91362.00 :green_circle: ( previous job: 80283.00, improvement: 113.80%)
fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2171.00 :small_red_triangle_up: ( previous job: 2215.00, degradation: 98.01%)
fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8285.00 :green_circle: ( previous job: 7540.00, improvement: 109.88%)
fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1354.00 :green_circle: ( previous job: 1130.00, improvement: 119.82%)
fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 397790.00 :green_circle: ( previous job: 369868.00, improvement: 107.55%)
fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 176305.00 :small_red_triangle_up: ( previous job: 179949.00, degradation: 97.97%)
fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 66835.00 :green_circle: ( previous job: 17567.00, improvement: 380.46%)
fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 82607.00 :green_circle: ( previous job: 79021.00, improvement: 104.54%)
fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8316.00 :green_circle: ( previous job: 7867.00, improvement: 105.71%)
fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2165.00 :green_circle: ( previous job: 1953.00, improvement: 110.86%)

marmarta suggested changes Mar 18, 2025

View reviewed changes

Comment thread qui/qubes-updater-base.css Outdated

alimirjamali force-pushed the prohibit_start_fixes branch 2 times, most recently from a6cdf7d to faac71f Compare March 18, 2025 12:32

marmarek added the openqa-pending label Mar 19, 2025

marmarek reviewed Mar 19, 2025

View reviewed changes

Comment thread qui/qubes-updater-base.css Outdated

alimirjamali force-pushed the prohibit_start_fixes branch from faac71f to ac58357 Compare March 19, 2025 06:35

Fix prohibit-start selection & tooltip

a474c64

alimirjamali force-pushed the prohibit_start_fixes branch from ac58357 to a474c64 Compare March 19, 2025 19:36

alimirjamali requested review from marmarek and marmarta March 19, 2025 19:43

marmarta approved these changes Mar 20, 2025

View reviewed changes

marmarek merged commit 03c3a1b into QubesOS:main Mar 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `prohibit-start` selection & tooltip#253

Fix `prohibit-start` selection & tooltip#253
marmarek merged 1 commit into
QubesOS:mainfrom
alimirjamali:prohibit_start_fixes

alimirjamali commented Mar 17, 2025

Uh oh!

codecov Bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

qubesos-bot commented Mar 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alimirjamali commented Mar 17, 2025

Uh oh!

codecov Bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

qubesos-bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Mar 17, 2025 •

edited

Loading

qubesos-bot commented Mar 19, 2025 •

edited

Loading