Updater: Enable qubesadmin caching#305
Conversation
DemiMarie
force-pushed
the
enable-caching
branch
from
ae4f65d to
7a7efb8
Compare
|
PipelineRetryFailed |
|
@marmarek , is this the only way to put in the caching? (this: enabling events); if yes, this makes sense, although I would love a less ugly way, because now I'm worried that asyncio will screw something up.... |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 92.99% 92.95% -0.04%
==========================================
Files 64 64
Lines 13312 13323 +11
==========================================
+ Hits 12379 12384 +5
- Misses 933 939 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Enabling caching could fix other issues too, like crashing when a VM is shut down behind the updater’s back. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026041101-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 31 fixed
Unstable testsDetails
Performance TestsPerformance degradation:9 performance degradations
Remaining performance tests:102 tests
|
|
openQA says no: |
|
This is due to the old version of |
|
No, do like we have it in other events-consuming components. |
DemiMarie
force-pushed
the
enable-caching
branch
from
7a7efb8 to
bd5e856
Compare
| gi.require_version("Gtk", "3.0") # isort:skip | ||
| from gi.repository import Gtk, Gdk, Gio # isort:skip | ||
|
|
||
| asyncio.set_event_loop_policy(GLibEventLoopPolicy()) |
There was a problem hiding this comment.
Duplicated line outside of try/except.
This avoids O(N^2) Admin API calls. Hopefully, this Fixes: QubesOS/qubes-issues#10775 Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
DemiMarie
force-pushed
the
enable-caching
branch
from
bd5e856 to
f827ba7
Compare
4 participants
This avoids O(N^2) Admin API calls.
Not tested (yet) as I don’t (anymore) have a convienent machine to test on, but I can make the edits to dom0 by hand at some point. Unit tests do pass.