qui/devices: add confirmation notification after successful detach#306
qui/devices: add confirmation notification after successful detach#306marmarek merged 1 commit intoQubesOS:mainfrom
Conversation
Previously only a 'Detaching...' notification was shown with no confirmation of completion. Add a second 'was detached' notification after success, consistent with qube shutdown two-step notifications. Fixes #10794
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 92.99% 92.96% -0.03%
==========================================
Files 64 64
Lines 13312 13313 +1
==========================================
- Hits 12379 12376 -3
- Misses 933 937 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032922-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests26 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 28 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:91 tests
|
|
Please reference the issue with full URL. Relative URL onky works when referencing the same repo. |
5 participants
Fixes #10794
Problem
When detaching a device via the Qubes Devices tray widget, only a
"Detaching device..." notification was shown. The user had no way of
knowing when the operation actually completed.
Fix
Added a second "X was detached from Y" notification after the detach
operation succeeds in
detach_from_vm()inbackend.py, consistentwith how qube shutdown already uses two notifications. The change was
minimal.