Skip to content

qui/devices: add confirmation notification after successful detach #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Mar 29, 2026
Merged

qui/devices: add confirmation notification after successful detach #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions qui/devices/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,12 @@ def detach_from_vm(self, vm: VM, with_aux_devices: bool = True):
self.backend_domain, self._ident, self.device_class
)
vm.vm_object.devices[self.device_class].detach(assignment)
self.gtk_app.emit_notification(
_("Device detached"),
_("{} was detached from {}.").format(self.description, vm),
Gio.NotificationPriority.NORMAL,
notification_id=self.notification_id,
)
if self.devices_to_attach_with_me and with_aux_devices:
for device in self.devices_to_attach_with_me:
if device is self:
Expand Down