Appmenu folders for organizing qubes#71
Open
amrosia wants to merge 8 commits into
Open
Conversation
Member
|
I think this is promising, but tests fail (the fail on desktop-linux-manager is known, but there is a bunch of fails for menu tests too). |
Introduce folder rows and folder assignment actions. Add VM feature hooks and tests for folder updates.
Separate Apps, Templates, and Service folder scopes. Store ordering and collapse state per scope for predictable UX.
Keep VM list state stable while assigning folder membership. Avoid refresh ordering that can clear visible selection/state.
Handle feature access errors gracefully and keep folder state consistent on delete events. Update app page tests to skip folder header rows when asserting VM ordering/state.
Extend app-page tests for folder create/assign/rename/delete, ordering, collapse behavior, scope-specific persistence, and menu entries. Add VM manager test for folder scope feature events. Adjust tests to avoid mock qubesd feature-set calls by using local feature dict/mocks where needed.
Author
|
Thanks for the review. I fixed the menu test failures. In my tests, the result was: 31 passed, 1 skipped, 7 warnings. I also added 5 tests for folder functionality in test_app_page.py and test_vmmanager.py Coverage includes create/assign/rename/delete, ordering and collapse behavior, scope-specific state handling, submenu entries, and VM feature-event refresh behavior. |
Member
|
PipelineRetryFailed |
Member
|
PipelineRetry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users have many qubes, the Applications pane becomes difficult to scan and navigate quickly. Related qubes are mixed in one long list, which makes common workflows slower.
This change adds folder-based organization to the VM list in the appmenu, so users can group related qubes and reduce visual clutter.
What this PR adds
Persistence model
Appmenu folder state is stored in qvm-features:
Warning: AI-generated code
This change set was written with AI, then tested manually.