Sync environment variables from the user session into systemd and dbus#257
Open
ArrayBolt3 wants to merge 1 commit intoQubesOS:mainfrom
Open
Sync environment variables from the user session into systemd and dbus#257ArrayBolt3 wants to merge 1 commit intoQubesOS:mainfrom
ArrayBolt3 wants to merge 1 commit intoQubesOS:mainfrom
Conversation
We're already syncing environment variables from the systemd user manager into the user session, but some variables may be set in the user session that aren't in the user manager or dbus-daemon by default. This interferes with applications that are launched by the user manager or dbus-daemon, such as Ptyxis and Kicksecure's fm-shim system. Sync environment variables from the user session into the systemd user manager and dbus-daemon to fix this. Fixes: QubesOS/qubes-issues#10759 Fixes: QubesOS/qubes-issues#10712
Contributor
|
Can some test be added that covers the initial issue and the current issue:
I think it will have to be an integration test. |
Contributor
Author
|
@ben-grande Where are the integration tests stored? |
Contributor
|
I never did an integration test outside of core-admin, but here is an example of pdf sanitizer using |
This was referenced Apr 17, 2026
Open
Fix for #10797: qvm-open-in-vm should now work in KDE-based cubes
QubesOS/qubes-core-agent-linux#642
Open
Contributor
|
Did not find an error on openqa related to this PR. |
Contributor
Author
|
Created QubesOS/qubes-core-admin#804 for the integration tests, will probably need partially re-worked before it can be merged. |
This was referenced Apr 23, 2026
Merged
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're already syncing environment variables from the systemd user manager into the user session, but some variables may be set in the user session that aren't in the user manager or dbus-daemon by default. This interferes with applications that are launched by the user manager or dbus-daemon, such as Ptyxis and Kicksecure's fm-shim system.
Sync environment variables from the user session into the systemd user manager and dbus-daemon to fix this.
Fixes: QubesOS/qubes-issues#10759
Fixes: QubesOS/qubes-issues#10712
(Note that I haven't finished testing if this fixes the Ptyxis terminal issue, but it seems like it should. I'll report back once I've tested that.)