Skip to content

Sync environment variables from the user session into systemd and dbus#257

Open
ArrayBolt3 wants to merge 1 commit intoQubesOS:mainfrom
ArrayBolt3:arraybolt3/env-sync-2
Open

Sync environment variables from the user session into systemd and dbus#257
ArrayBolt3 wants to merge 1 commit intoQubesOS:mainfrom
ArrayBolt3:arraybolt3/env-sync-2

Conversation

@ArrayBolt3
Copy link
Copy Markdown
Contributor

We're already syncing environment variables from the systemd user manager into the user session, but some variables may be set in the user session that aren't in the user manager or dbus-daemon by default. This interferes with applications that are launched by the user manager or dbus-daemon, such as Ptyxis and Kicksecure's fm-shim system.

Sync environment variables from the user session into the systemd user manager and dbus-daemon to fix this.

Fixes: QubesOS/qubes-issues#10759
Fixes: QubesOS/qubes-issues#10712

(Note that I haven't finished testing if this fixes the Ptyxis terminal issue, but it seems like it should. I'll report back once I've tested that.)

We're already syncing environment variables from the systemd user
manager into the user session, but some variables may be set in the user
session that aren't in the user manager or dbus-daemon by default. This
interferes with applications that are launched by the user manager or
dbus-daemon, such as Ptyxis and Kicksecure's fm-shim system.

Sync environment variables from the user session into the systemd user
manager and dbus-daemon to fix this.

Fixes: QubesOS/qubes-issues#10759
Fixes: QubesOS/qubes-issues#10712
@ben-grande
Copy link
Copy Markdown
Contributor

Can some test be added that covers the initial issue and the current issue:

  • don't clobber env vars
  • but do set them...

I think it will have to be an integration test.

@ArrayBolt3
Copy link
Copy Markdown
Contributor Author

@ben-grande Where are the integration tests stored?

@ben-grande
Copy link
Copy Markdown
Contributor

I never did an integration test outside of core-admin, but here is an example of pdf sanitizer using qubes.tests.extra:

https://github.com/QubesOS/qubes-app-linux-pdf-converter/blob/main/qubespdfconverter/tests/__init__.py

@qubesos-bot
Copy link
Copy Markdown

qubesos-bot commented Apr 17, 2026

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026043003-devel&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update

Failed tests

No failures!

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/170766#dependencies
Nothing fixed

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

@ben-grande
Copy link
Copy Markdown
Contributor

Did not find an error on openqa related to this PR.

@ArrayBolt3
Copy link
Copy Markdown
Contributor Author

Created QubesOS/qubes-core-admin#804 for the integration tests, will probably need partially re-worked before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants