Hide internal qubes from boot device selection#443
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 69.66% 69.66%
=======================================
Files 17 17
Lines 4008 4008
=======================================
Hits 2792 2792
Misses 1216 1216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| and not utils.get_feature(vm, "service.guivm", False) | ||
| and not getattr(vm, "template_for_dispvms", False) | ||
| ), | ||
| allow_internal=True |
There was a problem hiding this comment.
The commit message talks about hiding internal. There is already parameter for that just here, instead of the whole filter function. And IMO filtering-out all those (other) qubes isn't a good idea - for example excluding servicevm excludes sys-usb, which is a very valid choice (for example to boot from a USB stick plugged in).
There was a problem hiding this comment.
The commit message talks about hiding internal. There is already parameter for that just here, instead of the whole filter function.
allow_internal=False hides AdminVM also. The thing is, no other piece of code is using it, so perhaps we could drop the hiding of AdminVM. Just let me know if this is intended.
And IMO filtering-out all those (other) qubes isn't a good idea - for example excluding servicevm excludes sys-usb, which is a very valid choice (for example to boot from a USB stick plugged in).
sure, will allow servicevm.
ben-grande
force-pushed
the
preload-boot-from-device
branch
from
03cf816 to
8d028b2
Compare
|
test_10_do_backup fails now, but later on tests hang, so there is no full details of the failure... |
ben-grande
force-pushed
the
preload-boot-from-device
branch
from
8d028b2 to
6058c87
Compare
| and not utils.get_feature(vm, "service.audiovm", False) | ||
| and not utils.get_feature(vm, "service.guivm", False) | ||
| and not getattr(vm, "template_for_dispvms", False) |
There was a problem hiding this comment.
Similar to the PR in the other repo - please drop those excessive filters. Filtering out internal may be okay, but others should stay.
ben-grande
force-pushed
the
preload-boot-from-device
branch
from
6058c87 to
99f113a
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026040510-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests28 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 27 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:15 performance degradations
Remaining performance tests:96 tests
|
| filter_function=(lambda vm: | ||
| vm != self.vm | ||
| and vm.klass != "TemplateVM" | ||
| and not utils.get_feature(vm, "internal", False) |
There was a problem hiding this comment.
Is this still needed, given allow_internal=True is gone?
There was a problem hiding this comment.
Time has passed and I don't remember why I did this. Will fix.
ben-grande
force-pushed
the
preload-boot-from-device
branch
from
99f113a to
e3248b8
Compare
3 participants
For: QubesOS/qubes-issues#1512