Don't block main thread on qube hanging shutdown#450
Open
ben-grande wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Requires bumping qubesadmin in the requirements. |
Contributor
Author
|
PipelineRetryFailed |
ben-grande
force-pushed
the
long-shutdown
branch
2 times, most recently
from
6792ea4 to
f8d721f
Compare
Member
|
There are some pylint fails and test complaints, otherwise this looks fine |
The merge request to core-admin already avoids the main problem, of a hanging shutdown blocking qubesd. This change avoids a hanging shutdown blocking the interaction with the qube manager For: QubesOS/qubes-issues#10648 Fixes: QubesOS/qubes-issues#10074 Requires: QubesOS/qubes-core-admin#807 Requires: QubesOS/qubes-core-admin-client#469
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 69.67% 69.71% +0.04%
==========================================
Files 17 17
Lines 4017 4029 +12
==========================================
+ Hits 2799 2809 +10
- Misses 1218 1220 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge request to core-admin already avoids the main problem, of a hanging shutdown blocking qubesd. This change avoids a hanging shutdown blocking the interaction with the qube manager
For: QubesOS/qubes-issues#10648
Fixes: QubesOS/qubes-issues#10074
Requires: QubesOS/qubes-core-admin#807
Requires: QubesOS/qubes-core-admin-client#469