feat: Save slots#692
Open
alex-y-z wants to merge 2 commits into
Open
Conversation
Quenty
reviewed
May 14, 2026
| local SaveSlotData = require("SaveSlotData") | ||
| local ServiceBag = require("ServiceBag") | ||
|
|
||
| type SaveSlot = { |
Owner
There was a problem hiding this comment.
may want to name this SaveSlotData so people know it's a pure data-driven, not OOP
Quenty
reviewed
May 14, 2026
| end) | ||
| :Pipe({ | ||
| RxBrioUtils.map(function(slotIndex: number) | ||
| return dataStore:GetSubStore("saveSlots"):GetSubStore(tostring(slotIndex)) |
Owner
There was a problem hiding this comment.
needs the default slot to be the top level datastore
Quenty
reviewed
May 14, 2026
|
|
||
| return TieDefinition.new("HasSaveSlots", { | ||
| ActiveSlotIndex = TieDefinition.Types.PROPERTY, | ||
| MaxSlotCount = TieDefinition.Types.PROPERTY, |
Owner
There was a problem hiding this comment.
would add a slot changing event here
Quenty
reviewed
May 14, 2026
| MaxSlotCount = TieDefinition.Types.PROPERTY, | ||
|
|
||
| PromiseHasSlot = TieDefinition.Types.METHOD, | ||
| PromiseSelectSlot = TieDefinition.Types.METHOD, |
Owner
There was a problem hiding this comment.
need observe active slot api methods here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlayerDataStoreService wrapper for save slots.
Provides an interface for creating, manipulating, and observing slots such that consumers can seamlessly react to slot switching.