feat(chatproviderservice): convert package to --!strict typing#718
Merged
Conversation
Convert the ChatProviderService package's remaining --!nonstrict modules to --!strict, adding explicit type annotations following Nevermore conventions. Also fixes latent bugs surfaced by the type checker: the developer/admin tags passed a misnamed LocalizedText field (now TagLocalizedText) so localized text was never applied, and ChatTagKey was typed as a boolean in ChatTagBase though it holds the string tag key.
Owner
Author
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the remaining ChatProviderService package modules from --!nonstrict to --!strict with explicit Nevermore-style type annotations. Along the way it fixes two latent bugs the type checker surfaced: the developer and admin tags were built with a misnamed LocalizedText field (now TagLocalizedText) so their localized text was silently dropped, and ChatTagBase typed ChatTagKey as a boolean even though it stores the string tag key. No public API behavior changes otherwise.