feat(deathreport): convert package to --!strict#719
Merged
Conversation
Converts every non-strict source file in the deathreport package to --!strict, adding explicit type annotations to the death/kill/team tracker classes, DeathReportUtils, and the client service. Binder registrations now hoist their class requires to locals so the sanctioned `:: any` cast doesn't trip luau-lsp's require resolver. No runtime behavior changes.
Owner
Author
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts every non-strict source file in the deathreport package to --!strict, adding explicit type annotations across the death, kill, and team tracker classes, DeathReportUtils, and the client service. Binder registrations hoist their class requires to locals so the sanctioned any cast doesn't trip luau-lsp's require resolver. There are no runtime behavior changes.