Commit 7c40c86
test(conformance): converge on the shared compression-disabled fixture
The compression-disabled conformance coverage added here locally has now
landed centrally (vgi-rpc-python be1a7a6), so this repo converges onto it
rather than keeping a parallel copy.
- Fixture renamed ts_http_no_compression_port ->
conformance_http_no_compression_port, the name the shared suite looks up.
The name is load-bearing: the shared case resolves it by string literal
and *skips* rather than fails on a mismatch, so a rename would silently
stop testing this port. Noted in the docstring.
- The local TestResponseCompressionDisabled class is deleted outright. The
shared case subsumes both of its tests exactly -- same OPTIONS /health
probe, same present-and-empty assertions, same both-headers zstd request,
same "no codec claimed" check. A local test that duplicates the
conformance suite keeps passing while this port drifts from the others,
which is the failure mode the shared suite exists to prevent.
The worker needed no change: the --response-compression off flag added
earlier is exactly what the shared fixture drives.
Verified against the suite at be1a7a6: 6 passed, 0 skipped for the
-k Compression selection, and non-vacuous -- dropping the flag from the
fixture fails with `expected an empty advertisement, got ['zstd', 'gzip']`.
Note on CI reachability: ci.yml installs vgi-rpc from PyPI, and no released
version carries this class yet (it is four commits past v0.25.0, verified
against an installed 0.25.0). Until a release ships, CI does not skip these
cases -- it does not collect them at all, so their absence is silent rather
than reported. The fixture sits unused and harmless until then.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 9bd88c2 commit 7c40c86
1 file changed
Lines changed: 14 additions & 62 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
121 | 127 | | |
122 | 128 | | |
123 | 129 | | |
| |||
508 | 514 | | |
509 | 515 | | |
510 | 516 | | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | | - | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
559 | | - | |
560 | | - | |
561 | | - | |
562 | | - | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
571 | | - | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
0 commit comments