Update changelog and move rollbar reporting to a more restrictive executor. (#2422)

Author: creatorfromhell

.changelog/SNAPSHOTS/6.3.0.0-SNAPSHOT-10.md

@@ -39,6 +39,9 @@ Conditional components dynamically determine their output based on the current s
     - **Unlimited** when the shop has unlimited stock.
     - The remaining stock amount when the shop has available stock.
 
+## Internal Changes
+- Moved rollbar reporting to a more restrictive executor.
+
 ## Minor Changes
 - renamed price to price_solo for text-display configurations.
 - Added support for displaying the name of the song on a music disc using shop.use-song-for-disc-item in config.yml
@@ -53,4 +56,7 @@ Conditional components dynamically determine their output based on the current s
 - Deprecated IShopLayoutProvider#renderTrading
 - Deprecated IShopLayoutProvider#renderItem
 - Deprecated IShopLayoutProvider#renderPrice
-- Deprecated IShopLayoutProvider#renderLevels
+- Deprecated IShopLayoutProvider#renderLevels
+
+## Fixes
+- Fix ShopBenefitAddEvent not showing the cancel message(thanks to Warriorrrr)

quickshop-bukkit/src/main/java/com/ghostchu/quickshop/util/reporter/error/RollbarErrorReporter.java

@@ -238,7 +238,7 @@ public void resetIgnores() {
    */
   public void sendError(@NotNull final Throwable throwable, @NotNull final String... context) {
 
-    QuickExecutor.getCommonExecutor().submit(()->sendError0(throwable, context));
+    QuickExecutor.getErrorReportExecutor().submit(()->sendError0(throwable, context));
   }
 
   /**

quickshop-common/src/main/java/com/ghostchu/quickshop/common/util/QuickExecutor.java

@@ -14,6 +14,16 @@ public class QuickExecutor {
   private static ExecutorService COMMON_EXECUTOR = Executors.newCachedThreadPool();
   private static ExecutorService PRIMARY_PROFILE_IO_EXECUTOR = Executors.newWorkStealingPool(16);
   private static ExecutorService SECONDARY_PROFILE_IO_EXECUTOR = Executors.newWorkStealingPool(2);
+  private static final ExecutorService ERROR_REPORT_EXECUTOR = new ThreadPoolExecutor(
+          1,
+          1,
+          60L,
+          TimeUnit.SECONDS,
+          new LinkedBlockingQueue<>(100),r -> {
+            Thread t = new Thread(r, "QuickShop-ErrorReporter");
+            t.setDaemon(true);
+            return t;
+    }, new ThreadPoolExecutor.DiscardPolicy());
 
   static {
     HIKARICP_EXECUTOR = provideHikariCPExecutor();
@@ -35,6 +45,10 @@ public static ExecutorService provideHikariCPExecutor() {
     return Executors.newThreadPerTaskExecutor(Thread.ofVirtual().name("QuickShop-Database-Worker-", 0).factory());
   }
 
+  public static ExecutorService getErrorReportExecutor() {
+    return ERROR_REPORT_EXECUTOR;
+  }
+
   public static ExecutorService getCommonExecutor() {
 
     return COMMON_EXECUTOR;