Skip to content

[BUG] (DiscordSRV Addon + QS-Hikari) Incorrect tax display with shop tax. #2289

@shamgamer

Description

@shamgamer

Description

When a player buys an item from another player's shop with the tax set to shop, the tax that is displayed in the messages to the shop owner and in discord srv are incorrect.
discordsrv addon ignores shop side tax and just shows the ammount the player paid and taxes as 0$.
in game alert to shop owner just shows the ammount after taxes, not showing the taxed ammount or the ammount paid by the buying player.

Steps to reproduce

  1. setup a shop
  2. set taxes to bwe shop only (not player/both)
  3. buy an item from the shop
  4. encounter the issue

Expected Behaviour

bugged behaviour:
doesn't show taxes paid.
Buying player: 5$ (0$ Tax)
Shop player: 4.85$ (no tax displayed)
discord alert: you earn 5$ 0$ taxes

expected behaviour:
Buying player: 5$
Shop player: 4.85$ (0.25$ Taxed)
discord alert: you earn 4.85$ 0.25$ taxes

Screenshots

Image Image Image

/quickshop paste URL

https://ghost-chu.github.io/quickshop-hikari-paste-viewer/?remote=https%3A%2F%2Fbytebin.lucko.me%2Fe4MryamXV5

Additional Context

using purpur, shouldnt affect this i hope

Checklist

  • I'm running Paper, and not a fork
  • I confirm that Paper has been updated to the latest build
  • I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
  • I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
  • I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
  • I confirm that I have not read these checkboxes and therefore I just ticked them all.
  • I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions