[BUG]

[erkutay-ucar]

Description

players can change shop mode without having permission through gui

Steps to reproduce

give yourself only quickshop.create.cmd quickshop.create.sell
permissions even if you can't use the /qs buy command you can still change the mode using gui

Expected Behaviour

it must cancel the change mode action

Screenshots

No response

/quickshop paste URL

no need for log

Additional Context

this applies for other permissions like change price

Checklist

• I'm running Paper, and not a fork
• I confirm that Paper has been updated to the latest build
• I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)
• I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.
• I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.
• I confirm that I have not read these checkboxes and therefore I just ticked them all.
• I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

[creatorfromhell]

Description

players can change shop mode without having permission through guild

Steps to reproduce

give yourself only quickshop.create.cmd quickshop.create.sell permissions even if you can't use the /qs buy command you can still change the mode using gui

Expected Behaviour

it must cancel the change mode action

Screenshots

No response

/quickshop paste URL

no need for log

Additional Context

this applies for other permissions like change price

Checklist

• I'm running Paper, and not a fork[x] I confirm that Paper has been updated to the latest build[x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)[x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.[x] I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.[ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.[x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

What server software and mc version?

[creatorfromhell]

Description

players can change shop mode without having permission through guild

Steps to reproduce

give yourself only quickshop.create.cmd quickshop.create.sell permissions even if you can't use the /qs buy command you can still change the mode using gui

Expected Behaviour

it must cancel the change mode action

Screenshots

No response

/quickshop paste URL

no need for log

Additional Context

this applies for other permissions like change price

Checklist

• I'm running Paper, and not a fork[x] I confirm that Paper has been updated to the latest build[x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)[x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.[x] I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.[ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.[x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Also, the only permission players should have is quickshop.player.

[erkutay-ucar]

Description

players can change shop mode without having permission through guild

Steps to reproduce

give yourself only quickshop.create.cmd quickshop.create.sell permissions even if you can't use the /qs buy command you can still change the mode using gui

Expected Behaviour

it must cancel the change mode action

Screenshots

No response

/quickshop paste URL

no need for log

Additional Context

this applies for other permissions like change price

Checklist

• I'm running Paper, and not a fork[x] I confirm that Paper has been updated to the latest build[x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)[x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.[x] I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.[ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.[x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Also, the only permission players should have is quickshop.player.

leaf 1.21.4, i don't want them to use buying feature

[creatorfromhell]

Description

players can change shop mode without having permission through guild

Steps to reproduce

give yourself only quickshop.create.cmd quickshop.create.sell permissions even if you can't use the /qs buy command you can still change the mode using gui

Expected Behaviour

it must cancel the change mode action

Screenshots

No response

/quickshop paste URL

no need for log

Additional Context

this applies for other permissions like change price

Checklist

• I'm running Paper, and not a fork[x] I confirm that Paper has been updated to the latest build[x] I confirm that QuickShop-Hikari has been updated to the latest stable version released on Modrinth (or the latest CI version)[x] I confirm that I'm using QuickShop-Hikari, not QuickShop-Reremake, and I'm well aware that they're maintained by different people, and that Reremake issues shouldn't be reported here.[x] I confirm that I am running a server that is not a Hybrid Server, (e.g. Mohist, Magma, CatServer, Banner, etc.), and I am aware that QuickShop-Hikari may not function properly on a NeoForge/Forge/Fabric hybrid server, and I am running at my own risk on such a server program, and I am aware that the I run such server-side programs at my own risk and know that I will not receive any support or help for this behavior.[ ] I confirm that I have not read these checkboxes and therefore I just ticked them all.[x] I am well aware that if the Issue Ticket is not filled out correctly and completely, it will simply be closed without any response or reason.

Also, the only permission players should have is quickshop.player.

leaf 1.21.4, i don't want them to use buying feature

Please show what permissions your players have

[erkutay-ucar]

[creatorfromhell]

Cheers, I'll have a look when I'm done with my tagging PR/branch work.

[erkutay-ucar]

also stock information displays wrong amount

i think its because of using "final int stock = (shop.get().isBuying())? -1 : MarketUtils.getStockFromCache(shop.get());" method in signs plugin uses "shop.shopType().remainingStock(shop);" i might be wrong tho

[creatorfromhell]

also stock information displays wrong amount

i think its because of using "final int stock = (shop.get().isBuying())? -1 : MarketUtils.getStockFromCache(shop.get());" method in signs plugin uses "shop.shopType().remainingStock(shop);" i might be wrong tho

I'll have a look, the code pasted isn't related to the issue, the GUI has to use different methods for thread and performance purposes.

[erkutay-ucar]

were you able to look for the issue? i think this happens when getStockFromCache method doesn't run async

[creatorfromhell]

Not yet, I have some internal code changes I have to finish before going through this and some bug reports that came in the discord before still to review.

…

On Wed, Apr 1, 2026, 9:41 AM Erkutay UÇAR ***@***.***> wrote: *erkutay-ucar* left a comment (QuickShop-Community/QuickShop-Hikari#2308) <#2308 (comment)> were you able to look for the issue? i think this happens when getStockFromCache method doesn't run async — Reply to this email directly, view it on GitHub <#2308?email_source=notifications&email_token=AAHWW5IEZTXC3726VDUX5RL4TUMCHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJXGAYTSMRWHEZ2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4170192693>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHWW5LCQWQCN4KPQEYQHPL4TUMCHAVCNFSM6AAAAACWUARCIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNZQGE4TENRZGM> . You are receiving this because you commented.Message ID: ***@***.***>

[creatorfromhell]

Corrected in #2298