Fix hover event crash when shop item amount exceeds Paper limits#2288
Open
GoodrichDev wants to merge 2 commits intoQuickShop-Community:hikarifrom
Open
Fix hover event crash when shop item amount exceeds Paper limits#2288GoodrichDev wants to merge 2 commits intoQuickShop-Community:hikarifrom
GoodrichDev wants to merge 2 commits intoQuickShop-Community:hikarifrom
Conversation
Paper/Folia throws IllegalArgumentException when building an item hover event with stack amounts outside 1..99. Clamp only the hover-event copy of the ItemStack amount to 1..99 in PaperPlatform.setItemStackHoverEvent, preserving original shop stack amounts and behavior elsewhere. This prevents shop info panel warnings/crashes for large-amount shop items (e.g. 128)
Contributor
|
This reminded me it needed fixed, this should be done in the loading of custom stack sizes not in the individual areas. |
reverts previous change
Contributor
Author
Latest commit should address this. |
creatorfromhell
requested changes
Feb 26, 2026
| } | ||
| final ItemStack sanitized = stack.clone(); | ||
| sanitized.setAmount(normalizedAmount); | ||
| needUpdate = true; |
Contributor
There was a problem hiding this comment.
This needUpdate assignment is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper/Folia throws IllegalArgumentException when building an item hover event with stack amounts outside 1..99. Clamp only the hover-event copy of the ItemStack amount to 1..99 in PaperPlatform.setItemStackHoverEvent, preserving original shop stack amounts and behavior elsewhere. This prevents shop info panel warnings/crashes for large-amount shop items (e.g. 128)