Skip to content

Fix hover event crash when shop item amount exceeds Paper limits #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GoodrichDev wants to merge 2 commits into
base: hikari
Choose a base branch
from
Open

Fix hover event crash when shop item amount exceeds Paper limits #2288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a2cd6d
Fix hover event crash when shop item amount exceeds Paper limits
GoodrichDev Feb 25, 2026
ad2c52b
sanitize item stack instead of individual fix
GoodrichDev Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions quickshop-bukkit/src/main/java/com/ghostchu/quickshop/shop/ShopLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ public static class DataRawDatabaseInfo {
if(dataRecord.getEncoded() != null && !dataRecord.getEncoded().isEmpty()) {
Log.debug("Shop has correct encoded item type, loaded as usual.");

this.item = QuickShop.getInstance().platform().decodeStack(dataRecord.getEncoded());
this.item = sanitizeLoadedItemStack(QuickShop.getInstance().platform().decodeStack(dataRecord.getEncoded()));
this.newItem = item;

encodedLoaded = true;
Expand All @@ -364,7 +364,7 @@ public static class DataRawDatabaseInfo {
if(!encodedLoaded || this.item == null) {
Log.debug("Attempting to migrate shop to new encoded type....");

this.item = deserializeItem(dataRecord.getItem());
this.item = sanitizeLoadedItemStack(deserializeItem(dataRecord.getItem()));
this.newItem = item;
needUpdate = true;
}
Expand All @@ -383,6 +383,22 @@ public static class DataRawDatabaseInfo {
}
}

private @Nullable ItemStack sanitizeLoadedItemStack(@Nullable final ItemStack stack) {

if(stack == null) {
return null;
}
final int amount = stack.getAmount();
final int normalizedAmount = Math.max(1, Math.min(99, amount));
if(amount == normalizedAmount) {
return stack;
}
final ItemStack sanitized = stack.clone();
sanitized.setAmount(normalizedAmount);
needUpdate = true;
Copy link
Copy Markdown
Contributor

@creatorfromhell creatorfromhell Feb 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needUpdate assignment is unnecessary.

return sanitized;
}

private @Nullable YamlConfiguration deserializeExtra(@NotNull final String extraString) {

if(CommonUtil.isEmptyString(extraString)) {
Expand Down