Tagging, Favorites, Watching and more.#2298
Open
creatorfromhell wants to merge 29 commits intoQuickShop-Community:hikarifrom
Open
Tagging, Favorites, Watching and more.#2298creatorfromhell wants to merge 29 commits intoQuickShop-Community:hikarifrom
creatorfromhell wants to merge 29 commits intoQuickShop-Community:hikarifrom
Conversation
…. This includes the storage system, and database calls. This leaves the commands left to complete as the last item.
…he for shops without any tags already on removal calls.
…d methods. Tag management functionality is now ready for testing.
…to interface and implementation for API module, implement PlayerTagIndex in order to make tag queries o(1) instead of o(n)
…gration for improved tracking and research.
…a to extend ShopPrice.
…nt placeholder methods for generic price handling, and update related API interfaces.
…ocation` in shop-related classes, and add generic price comparison methods.
…nager. Removed unused tag parser class in AbstractShopManager.
… classes, and ensure case-insensitive handling for shop states.
…ed text handling, and update language keys with pagination and tag improvements.
…nd updating all usages across modules.
…on, add new command generation logic in `TagService`, update language keys for clarity.
…te frozen from modes. Fixed issue with permissions and toggling modes.
…dundant checks, and improve space and stock validation.
…with volume and pitch handling.
…fects with advanced customization options.
…for shop location handling in various subcommands, menu, and shop manager logic. Fix thread abuse within the history menu by moving the datarecords loading to be preloaded during the initialization phase of the command.
…e related localization keys, and refactor shop hover message construction for better readability and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Contribution Checklist
hikaribranch.Description of Changes
This PR introduces a new player shop tagging system and adds related player-facing commands for tagging, favorites, watchlists, and avoided shops.
What was changed:
/qs tag,/qs favorite,/qs watch, and/qs avoidcommand support.Why it was changed:
What issue does it solve:
User-facing, developer-facing, or internal:
Configuration Changes
config.yml.messages.yml.plugin.yml.Additional config-related changes reflected in the PR changelog:
playerDBFindUUIDTaskwith config optionuuid-lookup.allow-playerdb-uuidplayerDBFindNameTaskwith config optionuuid-lookup.allow-playerdb-nameskipDatabaseVersionCheckwith config optiondatabase.skip-version-checkIf config changes were made, explain them:
Migration Notes
Not a breaking change.
Potential admin notes:
config.yml.messages.yml.Related Issues / References
Testing Notes
How was this tested?
Additional notes:
Replace the checked items above if your actual testing differed.
Changelog Entry
Feature