feat: prevented global scope -> local scope duplicate entries by checking for global scope entries for variable names and arguments to prevent some naming issues

Author: Zffu

compiler/astoir_hir/src/scope.rs

@@ -2,7 +2,10 @@
 
 use compiler_global_scope::key::EntryKey;
 use compiler_typing::{TypedGlobalScope, TypedGlobalScopeEntry, raw::RawType, tree::Type};
-use diagnostics::{DiagnosticResult, DiagnosticSpanOrigin, builders::make_cannot_find};
+use diagnostics::{
+    DiagnosticResult, DiagnosticSpanOrigin, MaybeDiagnostic,
+    builders::{make_already_in_scope, make_cannot_find},
+};
 
 use crate::{
     ctx::{HIRBranchedContext, HIRFunction, HIRFunctionImpl},
@@ -29,6 +32,18 @@ impl HIRGlobalScopeStorage {
         }
     }
 
+    pub fn enforce_not_here<K: DiagnosticSpanOrigin>(
+        &mut self,
+        name: EntryKey,
+        origin: &K,
+    ) -> MaybeDiagnostic {
+        if self.scope.entry_to_ind.contains_key(&name) {
+            return Err(make_already_in_scope(origin, &name.name_hash).into());
+        }
+
+        Ok(())
+    }
+
     /// This doesn't automatically handle descriptors and implementations
     pub fn append<K: DiagnosticSpanOrigin>(
         &mut self,

compiler/astoir_hir_lowering/src/func.rs

@@ -88,6 +88,10 @@ pub fn lower_ast_function_declaration(
         let branch = curr_ctx.start_branch();
 
         for arg in &arguments {
+            context
+                .global_scope
+                .enforce_not_here(EntryKey { name_hash: arg.0 }, &*node)?;
+
             match curr_ctx.introduce_variable(arg.0, arg.1.clone(), true) {
                 Ok(_) => {}
                 Err(_) => return Err(make_already_in_scope(&*node, &arg.0).into()),

compiler/astoir_hir_lowering/src/var.rs

@@ -3,6 +3,7 @@ use astoir_hir::{
     ctx::{HIRBranchedContext, HIRContext, VariableKind, get_variable},
     nodes::{HIRNode, HIRNodeKind},
 };
+use compiler_global_scope::key::EntryKey;
 use diagnostics::{DiagnosticResult, builders::make_variable_uninit};
 
 use crate::{arrays::lower_ast_array_index_access, types::lower_ast_type, values::lower_ast_value};
@@ -18,6 +19,13 @@ pub fn lower_ast_variable_declaration(
         value,
     } = node.kind.clone()
     {
+        context.global_scope.enforce_not_here(
+            EntryKey {
+                name_hash: var_name.hash,
+            },
+            &*node,
+        )?;
+
         let lowered = lower_ast_type(context, var_type, &*node)?;
 
         let name_ind =

compiler/astoir_mir_lowering/src/vars.rs

@@ -28,13 +28,13 @@ pub fn lower_hir_variable_declaration(
 
         let fns_ind = match &ctx.hir_ctx.global_scope.scope.entries[func].entry_type {
             TypedGlobalScopeEntry::Function {
-                descriptor_ind,
+                descriptor_ind: _,
                 impl_ind,
             } => impl_ind,
             TypedGlobalScopeEntry::StructFunction {
-                descriptor_ind,
+                descriptor_ind: _,
                 impl_ind,
-                struct_type,
+                struct_type: _,
             } => impl_ind,
 
             _ => {