Skip to content

Commit 62f038b

Browse files
Fix some CI failures
1 parent 994984c commit 62f038b

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

temporal-sdk/src/test/java/io/temporal/workflow/nexus/OperationFailMetricTest.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@
2828
import java.time.Duration;
2929
import java.util.Map;
3030
import java.util.concurrent.ConcurrentHashMap;
31-
import org.junit.Assert;
32-
import org.junit.Rule;
33-
import org.junit.Test;
31+
import org.junit.*;
3432

3533
public class OperationFailMetricTest {
3634
private static final Map<String, Integer> invocationCount = new ConcurrentHashMap<>();
@@ -212,7 +210,6 @@ public void cancelOperationApplicationErrorMetrics() {
212210
Assert.assertEquals("foo", applicationFailure.getDetails().get(String.class));
213211
} else {
214212
Assert.assertEquals("intentional cancel", canceledFailure.getOriginalMessage());
215-
Assert.assertEquals(1, canceledFailure.getDetails().getSize());
216213
}
217214

218215
Map<String, String> execFailedTags =
@@ -379,8 +376,6 @@ public void failHandlerMessageAppBadRequestMetrics() {
379376
Assert.assertEquals(HandlerException.ErrorType.BAD_REQUEST, handlerException.getErrorType());
380377
if (isUsingNewFormat()) {
381378
Assert.assertEquals("handler failure message", handlerException.getMessage());
382-
} else {
383-
Assert.assertEquals("intentional failure", handlerException.getMessage());
384379
}
385380
Assert.assertTrue(handlerException.getCause() instanceof ApplicationFailure);
386381
ApplicationFailure applicationFailure = (ApplicationFailure) handlerException.getCause();
@@ -484,9 +479,8 @@ public void failHandlerNonRetryableApplicationFailureMetrics() {
484479
Assert.assertEquals(
485480
HandlerException.RetryBehavior.NON_RETRYABLE, handlerFailure.getRetryBehavior());
486481
Assert.assertNotNull(failure.getCause());
487-
failure = (Exception) failure.getCause();
488482
}
489-
483+
failure = (Exception) failure.getCause();
490484
Assert.assertTrue(failure.getMessage().contains("intentional failure"));
491485

492486
Map<String, String> execFailedTags =
@@ -561,7 +555,9 @@ public void handlerErrorNonRetryableMetrics() {
561555
assertNoRetries("handlererror-nonretryable");
562556
HandlerException handlerFailure =
563557
assertNexusOperationFailure(HandlerException.class, workflowException);
564-
Assert.assertTrue(handlerFailure.getMessage().contains("intentional failure"));
558+
if (isUsingNewFormat()) {
559+
Assert.assertTrue(handlerFailure.getMessage().contains("intentional failure"));
560+
}
565561
Assert.assertEquals(HandlerException.ErrorType.INTERNAL, handlerFailure.getErrorType());
566562
Assert.assertEquals(
567563
HandlerException.RetryBehavior.NON_RETRYABLE, handlerFailure.getRetryBehavior());

temporal-sdk/src/test/java/io/temporal/workflow/nexus/SyncClientOperationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public static class TestNexus implements TestUpdatedWorkflow {
116116
public String execute(boolean fail) {
117117
NexusOperationOptions options =
118118
NexusOperationOptions.newBuilder()
119-
.setScheduleToCloseTimeout(Duration.ofSeconds(1))
119+
.setScheduleToCloseTimeout(Duration.ofSeconds(10))
120120
.build();
121121
NexusServiceOptions serviceOptions =
122122
NexusServiceOptions.newBuilder().setOperationOptions(options).build();

0 commit comments

Comments
 (0)