Skip to content

Commit 6db0e46

Browse files
fix reset order to match core
1 parent 3af25d9 commit 6db0e46

3 files changed

Lines changed: 10 additions & 9 deletions

File tree

temporal-sdk/src/main/java/io/temporal/internal/activity/HeartbeatContextImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,10 @@ private void sendHeartbeatRequest(Object details) {
226226
metricsScope);
227227
if (status.getCancelRequested()) {
228228
lastException = new ActivityCanceledException(info);
229-
} else if (status.getActivityPaused()) {
230-
lastException = new ActivityPausedException(info);
231229
} else if (status.getActivityReset()) {
232230
lastException = new ActivityResetException(info);
231+
} else if (status.getActivityPaused()) {
232+
lastException = new ActivityPausedException(info);
233233
} else {
234234
lastException = null;
235235
}

temporal-sdk/src/main/java/io/temporal/internal/client/external/ManualActivityCompletionClientImpl.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,10 @@ public void recordHeartbeat(@Nullable Object details) throws CanceledFailure {
188188
metricsScope);
189189
if (status.getCancelRequested()) {
190190
throw new ActivityCanceledException();
191-
} else if (status.getActivityPaused()) {
192-
throw new ActivityPausedException();
193191
} else if (status.getActivityReset()) {
194192
throw new ActivityResetException();
193+
} else if (status.getActivityPaused()) {
194+
throw new ActivityPausedException();
195195
}
196196
} else {
197197
RecordActivityTaskHeartbeatByIdResponse status =
@@ -205,10 +205,10 @@ public void recordHeartbeat(@Nullable Object details) throws CanceledFailure {
205205
metricsScope);
206206
if (status.getCancelRequested()) {
207207
throw new ActivityCanceledException();
208-
} else if (status.getActivityPaused()) {
209-
throw new ActivityPausedException();
210208
} else if (status.getActivityReset()) {
211209
throw new ActivityResetException();
210+
} else if (status.getActivityPaused()) {
211+
throw new ActivityPausedException();
212212
}
213213
}
214214
} catch (Exception e) {

temporal-sdk/src/test/java/io/temporal/activity/ActivityResetTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,21 @@
1818
import org.junit.Rule;
1919
import org.junit.Test;
2020

21+
import static org.junit.Assume.assumeTrue;
22+
2123
public class ActivityResetTest {
2224

2325
@Rule
2426
public SDKTestWorkflowRule testWorkflowRule =
2527
SDKTestWorkflowRule.newBuilder()
2628
.setWorkflowTypes(TestWorkflowImpl.class)
2729
.setActivityImplementations(new HeartBeatingActivityImpl())
28-
.setUseExternalService(true)
2930
.build();
3031

3132
@Test
3233
public void activityReset() {
33-
// assumeTrue(
34-
// "Test Server doesn't support activity pause", SDKTestWorkflowRule.useExternalService);
34+
assumeTrue(
35+
"Test Server doesn't support activity pause", SDKTestWorkflowRule.useExternalService);
3536

3637
TestWorkflows.TestWorkflowReturnString workflow =
3738
testWorkflowRule.newWorkflowStub(TestWorkflows.TestWorkflowReturnString.class);

0 commit comments

Comments
 (0)