Clean up some code

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/internal/worker/ShutdownManager.java

@@ -71,7 +71,6 @@ public CompletableFuture<Void> waitForStickyQueueBalancer(
     balancer.disableNormalPoll();
     scheduledExecutorService.schedule(
         () -> {
-          log.info("DRAIN TIMEOUT PASSED!!!!");
           future.complete(null);
         },
         timeout.toMillis(),
@@ -297,18 +296,12 @@ public SlotSupplierDelayShutdown(
 
     @Override
     boolean isTerminated() {
-      if (slotSupplier.getIssuedSlots() > 0) {
-        log.info(
-            "Wait for release of slots of {} is in progress {}",
-            name,
-            slotSupplier.getIssuedSlots());
-      }
       return slotSupplier.getIssuedSlots() == 0;
     }
 
     @Override
     void onSlowTermination() {
-      log.info("Wait for release of slots of {} takes a long time", name);
+      log.warn("Wait for release of slots of {} takes a long time", name);
     }
 
     @Override

temporal-sdk/src/main/java/io/temporal/internal/worker/WorkflowWorker.java

@@ -206,7 +206,6 @@ public CompletableFuture<Void> shutdown(ShutdownManager shutdownManager, boolean
         pollerShutdown.thenCompose(
             ignore -> {
               if (!interruptTasks && stickyTaskQueueName != null) {
-                log.info("Shutting down worker for sticky task queue: {}", stickyTaskQueueName);
                 return shutdownManager.waitOnWorkerShutdownRequest(
                     service
                         .futureStub()

temporal-sdk/src/main/java/io/temporal/worker/tuning/PollerBehaviorAutoscaling.java

@@ -12,23 +12,57 @@ public final class PollerBehaviorAutoscaling implements PollerBehavior {
   private final int maxConcurrentTaskPollers;
   private final int initialConcurrentTaskPollers;
 
+  /**
+   * Creates a new PollerBehaviorAutoscaling with the specified parameters.
+   *
+   * @param minConcurrentTaskPollers Minimum number of concurrent task pollers.
+   * @param maxConcurrentTaskPollers Maximum number of concurrent task pollers.
+   * @param initialConcurrentTaskPollers Initial number of concurrent task pollers.
+   */
   public PollerBehaviorAutoscaling(
       int minConcurrentTaskPollers,
       int maxConcurrentTaskPollers,
       int initialConcurrentTaskPollers) {
+    if (minConcurrentTaskPollers < 1) {
+      throw new IllegalArgumentException("minConcurrentTaskPollers must be at least 1");
+    }
+    if (maxConcurrentTaskPollers < minConcurrentTaskPollers) {
+      throw new IllegalArgumentException(
+          "maxConcurrentTaskPollers must be greater than or equal to minConcurrentTaskPollers");
+    }
+    if (initialConcurrentTaskPollers < minConcurrentTaskPollers
+        || initialConcurrentTaskPollers > maxConcurrentTaskPollers) {
+      throw new IllegalArgumentException(
+          "initialConcurrentTaskPollers must be between minConcurrentTaskPollers and maxConcurrentTaskPollers");
+    }
     this.minConcurrentTaskPollers = minConcurrentTaskPollers;
     this.maxConcurrentTaskPollers = maxConcurrentTaskPollers;
     this.initialConcurrentTaskPollers = initialConcurrentTaskPollers;
   }
 
+  /**
+   * Gets the minimum number of concurrent task pollers.
+   *
+   * @return Minimum number of concurrent task pollers.
+   */
   public int getMinConcurrentTaskPollers() {
     return minConcurrentTaskPollers;
   }
 
+  /**
+   * Gets the maximum number of concurrent task pollers.
+   *
+   * @return Maximum number of concurrent task pollers.
+   */
   public int getMaxConcurrentTaskPollers() {
     return maxConcurrentTaskPollers;
   }
 
+  /**
+   * Gets the initial number of concurrent task pollers.
+   *
+   * @return Initial number of concurrent task pollers.
+   */
   public int getInitialMaxConcurrentTaskPollers() {
     return initialConcurrentTaskPollers;
   }

temporal-sdk/src/main/java/io/temporal/worker/tuning/PollerBehaviorSimpleMaximum.java

@@ -7,10 +7,24 @@
 public class PollerBehaviorSimpleMaximum implements PollerBehavior {
   private final int maxConcurrentTaskPollers;
 
+  /**
+   * Creates a new PollerBehaviorSimpleMaximum with the specified maximum number of concurrent task
+   * pollers.
+   *
+   * @param maxConcurrentTaskPollers Maximum number of concurrent task pollers.
+   */
   public PollerBehaviorSimpleMaximum(int maxConcurrentTaskPollers) {
+    if (maxConcurrentTaskPollers < 1) {
+      throw new IllegalArgumentException("maxConcurrentTaskPollers must be at least 1");
+    }
     this.maxConcurrentTaskPollers = maxConcurrentTaskPollers;
   }
 
+  /**
+   * Gets the maximum number of concurrent task pollers.
+   *
+   * @return Maximum number of concurrent task pollers.
+   */
   public int getMaxConcurrentTaskPollers() {
     return maxConcurrentTaskPollers;
   }