rename getApplicationErrorCategory to getCategory

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/failure/ApplicationFailure.java

@@ -234,7 +234,7 @@ public void setNextRetryDelay(Duration nextRetryDelay) {
     this.nextRetryDelay = nextRetryDelay;
   }
 
-  public ApplicationErrorCategory getApplicationErrorCategory() {
+  public ApplicationErrorCategory getCategory() {
     return category;
   }
 

temporal-sdk/src/main/java/io/temporal/failure/DefaultFailureConverter.java

@@ -263,7 +263,7 @@ private Failure exceptionToFailure(Throwable throwable) {
           ApplicationFailureInfo.newBuilder()
               .setType(ae.getType())
               .setNonRetryable(ae.isNonRetryable())
-              .setCategory(FailureUtils.categoryToProto(ae.getApplicationErrorCategory()));
+              .setCategory(FailureUtils.categoryToProto(ae.getCategory()));
       Optional<Payloads> details = ((EncodedValues) ae.getDetails()).toPayloads();
       if (details.isPresent()) {
         info.setDetails(details.get());

temporal-sdk/src/main/java/io/temporal/internal/common/FailureUtils.java

@@ -30,8 +30,7 @@ private FailureUtils() {}
 
   public static boolean isBenignApplicationFailure(@Nullable Throwable t) {
     if (t instanceof ApplicationFailure
-        && ((ApplicationFailure) t).getApplicationErrorCategory()
-            == ApplicationErrorCategory.BENIGN) {
+        && ((ApplicationFailure) t).getCategory() == ApplicationErrorCategory.BENIGN) {
       return true;
     }
     return false;

temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java

@@ -201,8 +201,7 @@ public void activityFailureMetricBenignApplicationError() {
         nonBenignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af = (ApplicationFailure) nonBenignErr.getCause().getCause();
     assertFalse(
-        "Failure should not be benign",
-        af.getApplicationErrorCategory() == ApplicationErrorCategory.BENIGN);
+        "Failure should not be benign", af.getCategory() == ApplicationErrorCategory.BENIGN);
     assertEquals("Non-benign activity failure", af.getOriginalMessage());
 
     reporter.assertCounter(
@@ -230,9 +229,7 @@ public void activityFailureMetricBenignApplicationError() {
         "Inner cause should be ApplicationFailure",
         benignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af2 = (ApplicationFailure) benignErr.getCause().getCause();
-    assertTrue(
-        "Failure should be benign",
-        af2.getApplicationErrorCategory() == ApplicationErrorCategory.BENIGN);
+    assertTrue("Failure should be benign", af2.getCategory() == ApplicationErrorCategory.BENIGN);
     assertEquals("Benign activity failure", af2.getOriginalMessage());
 
     // Expect metrics to remain unchanged for benign failure
@@ -274,8 +271,7 @@ public void localActivityFailureMetricBenignApplicationError() {
         nonBenignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af = (ApplicationFailure) nonBenignErr.getCause().getCause();
     assertFalse(
-        "Failure should not be benign",
-        af.getApplicationErrorCategory() == ApplicationErrorCategory.BENIGN);
+        "Failure should not be benign", af.getCategory() == ApplicationErrorCategory.BENIGN);
     assertEquals("Non-benign activity failure", af.getOriginalMessage());
 
     // Expect metrics to be incremented for non-benign failure
@@ -303,9 +299,7 @@ public void localActivityFailureMetricBenignApplicationError() {
         "Inner cause should be ApplicationFailure",
         benignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af2 = (ApplicationFailure) benignErr.getCause().getCause();
-    assertTrue(
-        "Failure should be benign",
-        af2.getApplicationErrorCategory() == ApplicationErrorCategory.BENIGN);
+    assertTrue("Failure should be benign", af2.getCategory() == ApplicationErrorCategory.BENIGN);
     assertEquals("Benign activity failure", af2.getOriginalMessage());
 
     // Expect metrics to remain unchanged for benign failure

temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowFailedMetricsTests.java

@@ -217,8 +217,7 @@ public void workflowFailureMetricBenignApplicationError() {
     Throwable cause1 = e1.getCause();
     assertTrue("Cause should be ApplicationFailure", cause1 instanceof ApplicationFailure);
     boolean isBenign =
-        ((ApplicationFailure) cause1).getApplicationErrorCategory()
-            == ApplicationErrorCategory.BENIGN;
+        ((ApplicationFailure) cause1).getCategory() == ApplicationErrorCategory.BENIGN;
     assertFalse("Failure should not be benign", isBenign);
     assertEquals("Non-benign failure", ((TemporalFailure) cause1).getOriginalMessage());
 
@@ -246,9 +245,7 @@ public void workflowFailureMetricBenignApplicationError() {
 
     Throwable cause2 = e2.getCause();
     assertTrue("Cause should be ApplicationFailure", cause2 instanceof ApplicationFailure);
-    isBenign =
-        ((ApplicationFailure) cause2).getApplicationErrorCategory()
-            == ApplicationErrorCategory.BENIGN;
+    isBenign = ((ApplicationFailure) cause2).getCategory() == ApplicationErrorCategory.BENIGN;
     assertTrue("Failure should be benign", isBenign);
     assertEquals("Benign failure", ((TemporalFailure) cause2).getOriginalMessage());