Respond to PR comments

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/client/WorkflowClient.java

@@ -159,6 +159,8 @@ static WorkflowClient newInstance(WorkflowServiceStubs service, WorkflowClientOp
    * @param runId Run id of the workflow execution.
    * @return Stub that implements workflowInterface and can be used to signal, update, or query it.
    * @deprecated Use {@link #newWorkflowStub(Class, WorkflowTargetOptions)} instead.
+   * @apiNote This method is deprecated because the returned stub does not properly account for the
+   *     runId.
    */
   @Deprecated
   <T> T newWorkflowStub(Class<T> workflowInterface, String workflowId, Optional<String> runId);
@@ -204,6 +206,8 @@ static WorkflowClient newInstance(WorkflowServiceStubs service, WorkflowClientOp
    * @param workflowType type of the workflow. Optional as it is used for error reporting only.
    * @return Stub that can be used to start workflow and later to signal or query it.
    * @deprecated Use {@link #newUntypedWorkflowStub(WorkflowTargetOptions, Optional)} instead.
+   * @apiNote This method is deprecated because the returned stub does not properly account for the
+   *     runId.
    */
   @Deprecated
   WorkflowStub newUntypedWorkflowStub(
@@ -217,6 +221,8 @@ WorkflowStub newUntypedWorkflowStub(
    * @param workflowType type of the workflow. Optional as it is used for error reporting only.
    * @return Stub that can be used to start workflow and later to signal or query it.
    * @deprecated Use {@link #newUntypedWorkflowStub(WorkflowTargetOptions, Optional)} instead.
+   * @apiNote This method is deprecated because the returned stub does not properly account for the
+   *     runId.
    */
   WorkflowStub newUntypedWorkflowStub(WorkflowExecution execution, Optional<String> workflowType);
 

temporal-sdk/src/main/java/io/temporal/client/WorkflowStub.java

@@ -19,7 +19,7 @@
  * WorkflowStub is a client side stub to a single workflow instance. It can be used to start,
  * signal, query, update, wait for completion and cancel a workflow execution. Created through
  * {@link WorkflowClient#newUntypedWorkflowStub(String, WorkflowOptions)} or {@link
- * WorkflowClient#newUntypedWorkflowStub(WorkflowExecution, Optional)}.
+ * WorkflowClient#newUntypedWorkflowStub(WorkflowTargetOptions, Optional)}.
  */
 public interface WorkflowStub {
 

temporal-sdk/src/main/java/io/temporal/client/WorkflowStubImpl.java

@@ -35,6 +35,9 @@ class WorkflowStubImpl implements WorkflowStub {
   // if null, this stub is created to bound to an existing execution.
   // This stub is created to bound to an existing execution otherwise.
   private final @Nullable WorkflowOptions options;
+  // The SDK used to have a bug where signals, queries, updates targeted the current run
+  // of the workflow even if the stub was created with a specific runId. This flag enables
+  // that legacy behavior for backward compatibility.
   private final boolean legacyTargeting;
   private final @Nullable String firstExecutionRunId;
 
@@ -603,8 +606,11 @@ private Throwable throwAsWorkflowFailureException(
   }
 
   private void populateExecutionAfterStart(WorkflowExecution startedExecution) {
+    // Currently we don't set the firstExecutionRunId on the stub after start because if the
+    // start request didn't create a new execution (e.g. because of WorkflowIdReusePolicy),
+    // the firstExecutionRunId should remain what it was before the start. To resolve this we
+    // need https://github.com/temporalio/temporal/issues/8537 to be implemented.
     this.startedExecution.set(startedExecution);
-    // this.firstExecutionRunId.set(startedExecution.getRunId());
     // bind to an execution without a runId, so queries follow runId chains by default
     this.execution.set(WorkflowExecution.newBuilder(startedExecution).setRunId("").build());
   }