Respond to PR comments

Author: Quinn-With-Two-Ns

temporal-sdk/src/test/java/io/temporal/internal/testing/ActivityTestingTest.java

@@ -80,7 +80,7 @@ public void testFailure() {
     } catch (ActivityFailure e) {
       assertTrue(e.getMessage().contains("Activity1"));
       assertTrue(e.getCause() instanceof ApplicationFailure);
-      assertEquals(((ApplicationFailure) e.getCause()).getType(), IOException.class.getName());
+      assertEquals(IOException.class.getName(), ((ApplicationFailure) e.getCause()).getType());
 
       assertEquals(
           "message='simulated', type='java.io.IOException', nonRetryable=false",

temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java

@@ -180,8 +180,8 @@ public void activityFailureMetricBenignApplicationError() {
         "Inner cause should be ApplicationFailure",
         nonBenignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af = (ApplicationFailure) nonBenignErr.getCause().getCause();
-    assertNotSame(
-        "Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN);
+    assertNotEquals(
+        "Failure should not be benign", ApplicationErrorCategory.BENIGN, af.getCategory());
     assertEquals("Non-benign activity failure", af.getOriginalMessage());
 
     reporter.assertCounter(
@@ -209,7 +209,7 @@ public void activityFailureMetricBenignApplicationError() {
         "Inner cause should be ApplicationFailure",
         benignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af2 = (ApplicationFailure) benignErr.getCause().getCause();
-    assertSame("Failure should be benign", af2.getCategory(), ApplicationErrorCategory.BENIGN);
+    assertEquals("Failure should be benign", ApplicationErrorCategory.BENIGN, af2.getCategory());
     assertEquals("Benign activity failure", af2.getOriginalMessage());
 
     // Expect metrics to remain unchanged for benign failure
@@ -250,8 +250,8 @@ public void localActivityFailureMetricBenignApplicationError() {
         "Inner cause should be ApplicationFailure",
         nonBenignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af = (ApplicationFailure) nonBenignErr.getCause().getCause();
-    assertNotSame(
-        "Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN);
+    assertNotEquals(
+        "Failure should not be benign", ApplicationErrorCategory.BENIGN, af.getCategory());
     assertEquals("Non-benign activity failure", af.getOriginalMessage());
 
     // Expect metrics to be incremented for non-benign failure
@@ -279,7 +279,7 @@ public void localActivityFailureMetricBenignApplicationError() {
         "Inner cause should be ApplicationFailure",
         benignErr.getCause().getCause() instanceof ApplicationFailure);
     ApplicationFailure af2 = (ApplicationFailure) benignErr.getCause().getCause();
-    assertSame("Failure should be benign", af2.getCategory(), ApplicationErrorCategory.BENIGN);
+    assertEquals("Failure should be benign", ApplicationErrorCategory.BENIGN, af2.getCategory());
     assertEquals("Benign activity failure", af2.getOriginalMessage());
 
     // Expect metrics to remain unchanged for benign failure

temporal-test-server/src/test/java/io/temporal/testserver/functional/NexusWorkflowTest.java

@@ -552,7 +552,7 @@ public void testNexusOperationTimeout_BeforeStart() {
 
       // Poll again to verify task is resent on timeout
       PollNexusTaskQueueResponse nextNexusPollResp = pollNexusTask().get();
-      Assert.assertFalse(nexusPollResp.getTaskToken().equals(nextNexusPollResp.getTaskToken()));
+      Assert.assertNotEquals(nexusPollResp.getTaskToken(), nextNexusPollResp.getTaskToken());
     } catch (Exception e) {
       Assert.fail(e.getMessage());
     }