respond to PR comments

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/internal/worker/AdjustableSemaphore.java

@@ -14,7 +14,11 @@ public final class AdjustableSemaphore {
    */
   private int maxPermits = 0;
 
-  /** New instances should be configured with setMaxPermits(). */
+  /**
+   * Create a new adjustable semaphore with the given number of initial permits.
+   *
+   * @param initialPermits the initial number of permits, must be at least 1
+   */
   public AdjustableSemaphore(int initialPermits) {
     if (initialPermits < 1) {
       throw new IllegalArgumentException(
@@ -48,8 +52,8 @@ synchronized void setMaxPermits(int newMax) {
       this.semaphore.release(delta);
     } else {
       // delta < 0.
-      // reducePermits needs a positive #, though.
-      this.semaphore.reducePermits(delta * -1);
+      // reducePermits needs a positive #
+      this.semaphore.reducePermits(Math.abs(delta));
     }
 
     this.maxPermits = newMax;

temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncPoller.java

@@ -316,13 +316,13 @@ public void run() {
    */
   @ThreadSafe
   class PollQueueBalancer {
-    Map<String, AtomicInteger> taskCounts = new HashMap<>();
+    Map<String, Integer> taskCounts = new HashMap<>();
     private final Lock balancerLock = new ReentrantLock();
     private final Condition balancerCondition = balancerLock.newCondition();
 
     void startPoll(String pollerName) {
       balancerLock.lock();
-      int currentPolls = taskCounts.get(pollerName).addAndGet(1);
+      Integer currentPolls = taskCounts.compute(pollerName, (k, v) -> v + 1);
       if (currentPolls == 1) {
         balancerCondition.signalAll();
       }
@@ -335,7 +335,7 @@ void endPoll(String pollerName) {
         balancerLock.unlock();
         return;
       }
-      int currentPolls = taskCounts.get(pollerName).addAndGet(-1);
+      Integer currentPolls = taskCounts.compute(pollerName, (k, v) -> v - 1);
       if (currentPolls == 0) {
         balancerCondition.signalAll();
       }
@@ -344,7 +344,7 @@ void endPoll(String pollerName) {
 
     void addPoller(String pollerName) {
       balancerLock.lock();
-      taskCounts.put(pollerName, new AtomicInteger(0));
+      taskCounts.put(pollerName, 0);
       balancerCondition.signalAll();
       balancerLock.unlock();
     }
@@ -362,13 +362,13 @@ void balance(String p) throws InterruptedException {
         balancerLock.lock();
         try {
           // If this poller has no tasks then we can unblock immediately
-          if (taskCounts.get(p).get() == 0) {
+          if (taskCounts.get(p) == 0) {
             return;
           }
           // Check if all tasks have at least one poll request
           boolean allOtherTasksHavePolls = true;
           for (String task : taskCounts.keySet()) {
-            if (!Objects.equals(task, p) && taskCounts.get(task).get() == 0) {
+            if (!Objects.equals(task, p) && taskCounts.get(task) == 0) {
               allOtherTasksHavePolls = false;
               break;
             }