fix up

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncActivityPollTask.java

@@ -98,6 +98,9 @@ public CompletableFuture<ActivityTask> poll(SlotPermit permit) {
                           .withOption(METRICS_TAGS_CALL_OPTIONS_KEY, metricsScope)
                           .pollActivityTaskQueue(pollRequest)));
     } catch (Exception e) {
+      MetricsTag.tagged(metricsScope, PollerTypeMetricsTag.PollerType.ACTIVITY_TASK)
+          .gauge(MetricsType.NUM_POLLERS)
+          .update(pollGauge.decrementAndGet());
       throw new RuntimeException(e);
     }
 

temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncNexusPollTask.java

@@ -90,6 +90,9 @@ public CompletableFuture<NexusTask> poll(SlotPermit permit) {
                           .withOption(METRICS_TAGS_CALL_OPTIONS_KEY, metricsScope)
                           .pollNexusTaskQueue(pollRequest)));
     } catch (Exception e) {
+      MetricsTag.tagged(metricsScope, PollerTypeMetricsTag.PollerType.NEXUS_TASK)
+          .gauge(MetricsType.NUM_POLLERS)
+          .update(pollGauge.decrementAndGet());
       throw new RuntimeException(e);
     }
 

temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncPoller.java

@@ -213,30 +213,30 @@ public void run() {
           }
 
           if (shouldTerminate()) {
-            return;
+            continue;
           }
 
           pollerBalancer.balance(asyncTaskPoller.getLabel());
           if (shouldTerminate()) {
-            return;
+            continue;
           }
           // Reserve a slot for the poll request
           SlotSupplierFuture future;
           try {
             future = slotSupplier.reserveSlot(slotReservationData);
           } catch (Exception e) {
             log.warn("Error while trying to reserve a slot", e.getCause());
-            return;
+            continue;
           }
           permit = BasePoller.getSlotPermitAndHandleInterrupts(future, slotSupplier);
           if (permit == null || shouldTerminate()) {
-            return;
+            continue;
           }
 
           pollerSemaphore.acquire();
           pollerSemaphoreAcquired = true;
           if (shouldTerminate()) {
-            return;
+            continue;
           }
           workerMetricsScope.counter(MetricsType.POLLER_START_COUNTER).inc(1);
 
@@ -299,13 +299,13 @@ public void run() {
           if (shouldTerminate()) {
             pollerBalancer.removePoller(asyncTaskPoller.getLabel());
             abort = true;
+            log.info(
+                "Poll loop is terminated: {} - {}",
+                AsyncPoller.this.getClass().getSimpleName(),
+                asyncTaskPoller.getLabel());
           }
         }
       }
-      log.info(
-          "Poll loop is terminated: {} - {}",
-          AsyncPoller.this.getClass().getSimpleName(),
-          asyncTaskPoller.getLabel());
     }
   }
 

temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncWorkflowPollTask.java

@@ -136,6 +136,9 @@ public CompletableFuture<WorkflowTask> poll(SlotPermit permit)
                           .withOption(METRICS_TAGS_CALL_OPTIONS_KEY, metricsScope)
                           .pollWorkflowTaskQueue(pollRequest)));
     } catch (Exception e) {
+      MetricsTag.tagged(metricsScope, taskQueueTagValue)
+          .gauge(MetricsType.NUM_POLLERS)
+          .update(pollGauge.decrementAndGet());
       throw new RuntimeException(e);
     }