remove some debug logging

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/internal/worker/AsyncPoller.java

@@ -15,6 +15,7 @@
 import java.util.concurrent.locks.Condition;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
+import javax.annotation.concurrent.ThreadSafe;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -34,7 +35,7 @@ final class AsyncPoller<T extends ScalingTask> extends BasePoller<T> {
   private final Thread.UncaughtExceptionHandler uncaughtExceptionHandler =
       new PollerUncaughtExceptionHandler();
   private final PollQueueBalancer balancer =
-      new PollQueueBalancer(); // Used to balance the number of pollers across threads
+      new PollQueueBalancer(); // Used to balance the number of slots across pollers
 
   AsyncPoller(
       TrackingSlotSupplier<?> slotSupplier,
@@ -129,7 +130,6 @@ public CompletableFuture<Void> shutdown(ShutdownManager shutdownManager, boolean
         .thenApply(
             (f) -> {
               for (PollTaskAsync<T> asyncTaskPoller : asyncTaskPollers) {
-                log.info("Shutting down async poller: {} !!!!", asyncTaskPoller);
                 try {
                   asyncTaskPoller.cancel(new RuntimeException("Shutting down poller"));
                 } catch (Throwable e) {
@@ -259,15 +259,14 @@ public void run() {
                     pollerSemaphore.release();
                     pollScaleReportHandle.report(task, e);
                     if (e != null) {
-                      // uncaughtExceptionHandler.uncaughtException(Thread.currentThread(), e);
+                      uncaughtExceptionHandler.uncaughtException(Thread.currentThread(), e);
                       pollBackoffThrottler.failure(
                           (e instanceof StatusRuntimeException)
                               ? ((StatusRuntimeException) e).getStatus().getCode()
                               : Status.Code.UNKNOWN);
                       slotSupplier.releaseSlot(SlotReleaseReason.neverUsed(), finalPermit);
                       return null;
                     }
-                    log.trace("$$$$$ Picked up task: {}", task);
                     if (task != null) {
                       taskExecutor.process(task);
                     } else {
@@ -284,7 +283,6 @@ public void run() {
         } catch (PollTaskAsyncAbort ab) {
           abort = true;
         } catch (Throwable e) {
-          log.error("Error in process task loop", e);
           if (e instanceof InterruptedException) {
             // we restore the flag here, so it can be checked and processed (with exit) in finally.
             Thread.currentThread().interrupt();
@@ -302,23 +300,19 @@ public void run() {
           }
 
           if (shouldTerminate()) {
-            log.info(
-                "ABORT {} permit {}, pollRequestMade {}",
-                asyncTaskPoller.getLabel(),
-                permit,
-                pollRequestMade);
             balancer.removePoller(asyncTaskPoller.getLabel());
             abort = true;
           }
         }
       }
       log.info(
-          "poll loop is terminated: {}, slotsReserved {}",
-          asyncTaskPoller.getLabel(),
-          slotsReserved);
+          "poll loop is terminated: {} - {}",
+          AsyncPoller.this.getClass().getSimpleName(),
+          asyncTaskPoller.getLabel());
     }
   }
 
+  @ThreadSafe
   class PollQueueBalancer {
     Map<String, AtomicInteger> taskCounts = new HashMap<>();
     private final Lock balancerLock = new ReentrantLock();
@@ -336,7 +330,6 @@ void startPoll(String pollerName) {
     void endPoll(String pollerName) {
       balancerLock.lock();
       if (!taskCounts.containsKey(pollerName)) {
-        log.info("endPoll has null key for tasks {}", pollerName);
         balancerLock.unlock();
         return;
       }
@@ -349,13 +342,7 @@ void endPoll(String pollerName) {
 
     void addPoller(String pollerName) {
       balancerLock.lock();
-      log.info("addPoller {}", pollerName);
       taskCounts.put(pollerName, new AtomicInteger(0));
-      if (!taskCounts.containsKey(pollerName)) {
-        log.info("????? has null key for task {}", pollerName);
-        balancerLock.unlock();
-        return;
-      }
       balancerCondition.signalAll();
       balancerLock.unlock();
     }

temporal-sdk/src/main/java/io/temporal/internal/worker/WorkflowWorker.java

@@ -222,20 +222,16 @@ public CompletableFuture<Void> shutdown(ShutdownManager shutdownManager, boolean
             }),
         pollerShutdown
             .thenCompose(
-                ignore -> {
-                  log.info("Waiting for workflow executor slots to be released: {}", supplierName);
-                  return !interruptTasks
-                      ? shutdownManager.waitForSupplierPermitsReleasedUnlimited(
-                          slotSupplier, supplierName)
-                      : CompletableFuture.completedFuture(null);
-                })
+                ignore ->
+                    !interruptTasks
+                        ? shutdownManager.waitForSupplierPermitsReleasedUnlimited(
+                            slotSupplier, supplierName)
+                        : CompletableFuture.completedFuture(null))
             .thenCompose(
-                ignore -> {
-                  log.info("Shutting down poll task executor: {}", pollTaskExecutor);
-                  return pollTaskExecutor != null
-                      ? pollTaskExecutor.shutdown(shutdownManager, interruptTasks)
-                      : CompletableFuture.completedFuture(null);
-                })
+                ignore ->
+                    pollTaskExecutor != null
+                        ? pollTaskExecutor.shutdown(shutdownManager, interruptTasks)
+                        : CompletableFuture.completedFuture(null))
             .exceptionally(
                 e -> {
                   log.error("Unexpected exception during shutdown", e);