[record_use] Run build hooks and link hooks in separate targets (flutter#184880)

Bug:

* dart-lang/native#2690

Splits the build and link hooks into separate `Target`s so that the
build hooks can run concurrently with gen_kernel, dart2js, and
dart2wasm.

Caching tests added:

* Changing Dart code and recorded uses causes no build hooks rerun but
link hooks rerun.
* Changing Dart code but no recorded uses casus no link hooks rerun.
* Changing build hooks (or its dependencies) causes build hooks to
rerun, but not link hooks to rerun of the outputs of the build hooks
didn't change.
* Changing the build hook outputs causes the link hooks to rerun.

Fixes the test case:

* Properly adds the dependencies to both the build and link hook.

Also refactors the targets to better naming:

* `DartBuild` -> `BuildHooks` (name `dart_build` -> `build_hooks`)
* `DartLink` -> `LinkHooks` (name `dart_link` -> `link_hooks`)

And simplifies the amount of targets:

* removed the `ForNative` and `ForWeb` variants and made the targets a
bit more configurable instead.

Author: dcharkes

dev/integration_tests/record_use_test_package/hook/build.dart

@@ -8,14 +8,16 @@ import 'package:hooks/hooks.dart';
 void main(List<String> args) async {
   await build(args, (BuildInput input, BuildOutputBuilder output) async {
     if (input.config.buildAssetTypes.contains('data_assets/data')) {
+      final Uri file = input.packageRoot.resolve('data/translations.json');
       output.assets.data.add(
         DataAsset(
           package: input.packageName,
           name: 'data/translations.json',
-          file: input.packageRoot.resolve('data/translations.json'),
+          file: file,
         ),
         routing: input.config.linkingEnabled ? ToLinkHook(input.packageName) : const ToAppBundle(),
       );
+      output.dependencies.add(file);
     }
   });
 }

dev/integration_tests/record_use_test_package/hook/link.dart

@@ -17,6 +17,8 @@ void main(List<String> args) async {
       return;
     }
 
+    output.dependencies.add(translationAsset.asDataAsset.file);
+
     final Recordings? recordings = await input.recordings;
     if (recordings == null) {
       // Record use not enabled, return full translations file.

packages/flutter_tools/lib/src/build_system/targets/android.dart

@@ -31,7 +31,7 @@ abstract class AndroidAssetBundle extends Target {
   @override
   List<Source> get inputs => const <Source>[
     Source.pattern('{BUILD_DIR}/app.dill'),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
     ...IconTreeShaker.inputs,
   ];
 
@@ -72,7 +72,7 @@ abstract class AndroidAssetBundle extends Target {
           .file(isolateSnapshotData)
           .copySync(outputDirectory.childFile('isolate_snapshot_data').path);
     }
-    final DartHooksResult dartHookResult = await DartBuild.loadHookResult(environment);
+    final DartHooksResult dartHookResult = await LinkHooks.loadHookResult(environment);
     final Depfile assetDepfile = await copyAssets(
       environment,
       outputDirectory,
@@ -94,7 +94,7 @@ abstract class AndroidAssetBundle extends Target {
 
   @override
   List<Target> get dependencies => const <Target>[
-    DartBuildForNative(),
+    LinkHooks(),
     KernelSnapshot(),
     InstallCodeAssets(),
   ];

packages/flutter_tools/lib/src/build_system/targets/assets.dart

@@ -272,14 +272,14 @@ class CopyAssets extends Target {
   String get name => 'copy_assets';
 
   @override
-  List<Target> get dependencies => const <Target>[DartBuildForNative(), KernelSnapshot()];
+  List<Target> get dependencies => const <Target>[LinkHooks(), KernelSnapshot()];
 
   @override
   List<Source> get inputs => const <Source>[
     Source.pattern(
       '{FLUTTER_ROOT}/packages/flutter_tools/lib/src/build_system/targets/assets.dart',
     ),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
     ...IconTreeShaker.inputs,
     ...ShaderCompiler.inputs,
   ];
@@ -302,7 +302,7 @@ class CopyAssets extends Target {
     final buildMode = BuildMode.fromCliName(buildModeEnvironment);
     final Directory output = environment.buildDir.childDirectory('flutter_assets');
     output.createSync(recursive: true);
-    final DartHooksResult dartHookResult = await DartBuild.loadHookResult(environment);
+    final DartHooksResult dartHookResult = await LinkHooks.loadHookResult(environment);
     final Depfile depfile = await copyAssets(
       environment,
       output,

packages/flutter_tools/lib/src/build_system/targets/common.dart

@@ -40,7 +40,7 @@ class CopyFlutterBundle extends Target {
     Source.artifact(Artifact.vmSnapshotData, mode: BuildMode.debug),
     Source.artifact(Artifact.isolateSnapshotData, mode: BuildMode.debug),
     Source.pattern('{BUILD_DIR}/app.dill'),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
     ...IconTreeShaker.inputs,
     ...ShaderCompiler.inputs,
   ];
@@ -50,7 +50,7 @@ class CopyFlutterBundle extends Target {
     Source.pattern('{OUTPUT_DIR}/vm_snapshot_data'),
     Source.pattern('{OUTPUT_DIR}/isolate_snapshot_data'),
     Source.pattern('{OUTPUT_DIR}/kernel_blob.bin'),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
   ];
 
   @override
@@ -87,7 +87,7 @@ class CopyFlutterBundle extends Target {
           .file(isolateSnapshotData)
           .copySync(environment.outputDir.childFile('isolate_snapshot_data').path);
     }
-    final DartHooksResult dartHookResult = await DartBuild.loadHookResult(environment);
+    final DartHooksResult dartHookResult = await LinkHooks.loadHookResult(environment);
     final Depfile assetDepfile = await copyAssets(
       environment,
       environment.outputDir,
@@ -109,7 +109,7 @@ class CopyFlutterBundle extends Target {
 
   @override
   List<Target> get dependencies => const <Target>[
-    DartBuildForNative(),
+    LinkHooks(),
     KernelSnapshot(),
     InstallCodeAssets(),
   ];

packages/flutter_tools/lib/src/build_system/targets/ios.dart

@@ -622,14 +622,14 @@ abstract class IosAssetBundle extends Target {
     KernelSnapshot(),
     InstallCodeAssets(),
     _IssueLaunchRootViewControllerAccess(),
-    DartBuildForNative(),
+    LinkHooks(),
   ];
 
   @override
   List<Source> get inputs => const <Source>[
     Source.pattern('{BUILD_DIR}/App.framework/App'),
     Source.pattern('{PROJECT_DIR}/pubspec.yaml'),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
     ...IconTreeShaker.inputs,
     ...ShaderCompiler.inputs,
   ];
@@ -710,7 +710,7 @@ abstract class IosAssetBundle extends Target {
     final String? flavor = await flutterProject.ios.parseFlavorFromConfiguration(environment);
 
     // Copy the assets.
-    final DartHooksResult dartHookResult = await DartBuild.loadHookResult(environment);
+    final DartHooksResult dartHookResult = await LinkHooks.loadHookResult(environment);
     final Depfile assetDepfile = await copyAssets(
       environment,
       assetDirectory,

packages/flutter_tools/lib/src/build_system/targets/linux.dart

@@ -94,7 +94,7 @@ abstract class BundleLinuxAssets extends Target {
 
   @override
   List<Target> get dependencies => <Target>[
-    const DartBuildForNative(),
+    const LinkHooks(),
     const KernelSnapshot(),
     const InstallCodeAssets(),
     UnpackLinux(targetPlatform),
@@ -104,7 +104,7 @@ abstract class BundleLinuxAssets extends Target {
   List<Source> get inputs => const <Source>[
     Source.pattern('{FLUTTER_ROOT}/packages/flutter_tools/lib/src/build_system/targets/linux.dart'),
     Source.pattern('{PROJECT_DIR}/pubspec.yaml'),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
     ...IconTreeShaker.inputs,
   ];
 
@@ -130,7 +130,7 @@ abstract class BundleLinuxAssets extends Target {
           .copySync(outputDirectory.childFile('kernel_blob.bin').path);
     }
     final String versionInfo = getVersionInfo(environment.defines);
-    final DartHooksResult dartHookResult = await DartBuild.loadHookResult(environment);
+    final DartHooksResult dartHookResult = await LinkHooks.loadHookResult(environment);
     final Depfile depfile = await copyAssets(
       environment,
       outputDirectory,

packages/flutter_tools/lib/src/build_system/targets/macos.dart

@@ -382,12 +382,12 @@ abstract class MacOSBundleFlutterAssets extends Target {
   const MacOSBundleFlutterAssets();
 
   @override
-  List<Target> get dependencies => const <Target>[DartBuildForNative()];
+  List<Target> get dependencies => const <Target>[LinkHooks()];
 
   @override
   List<Source> get inputs => const <Source>[
     Source.pattern('{BUILD_DIR}/App.framework/App'),
-    Source.pattern('{BUILD_DIR}/${DartBuild.dartHookResultFilename}'),
+    Source.pattern('{BUILD_DIR}/${LinkHooks.resultFilename}'),
     ...IconTreeShaker.inputs,
   ];
 
@@ -446,7 +446,7 @@ abstract class MacOSBundleFlutterAssets extends Target {
     final FlutterProject flutterProject = FlutterProject.fromDirectory(environment.projectDir);
     final String? flavor = await flutterProject.macos.parseFlavorFromConfiguration(environment);
 
-    final DartHooksResult dartHookResult = await DartBuild.loadHookResult(environment);
+    final DartHooksResult dartHookResult = await LinkHooks.loadHookResult(environment);
     final Depfile assetDepfile = await copyAssets(
       environment,
       assetDirectory,