Skip to content

Commit 4f334ab

Browse files
authored
Fixing WindowManagerTest::DialogCanNeverBeFullscreen possibly hanging (flutter#177179)
fixes flutter#177172 I believe the issue is that the struct was not fully initialized (which is usually not a problem, but can sometimes get garbage values and start hanging). The solution is probably to initialize the struct. Let's see if it fixes CI :) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
1 parent c232620 commit 4f334ab

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

engine/src/flutter/shell/platform/windows/window_manager_unittests.cc

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -368,13 +368,12 @@ TEST_F(WindowManagerTest, DialogCanNeverBeFullscreen) {
368368
IsolateScope isolate_scope(isolate());
369369

370370
DialogWindowCreationRequest creation_request{
371-
.preferred_size =
372-
{
373-
.has_preferred_view_size = true,
374-
.preferred_view_width = 800,
375-
.preferred_view_height = 600,
376-
},
377-
};
371+
.preferred_size = {.has_preferred_view_size = true,
372+
.preferred_view_width = 800,
373+
.preferred_view_height = 600},
374+
.preferred_constraints = {.has_view_constraints = false},
375+
.title = L"Hello World",
376+
.parent_or_null = nullptr};
378377

379378
const int64_t view_id =
380379
InternalFlutterWindows_WindowManager_CreateDialogWindow(

0 commit comments

Comments
 (0)