Rename noFrequencyBasedMinification to useFrequencyBasedMinification (flutter#182684)

# Rename noFrequencyBasedMinification to useFrequencyBasedMinification

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This PR renames the parameter `noFrequencyBasedMinification` on
`JsCompilerConfig` to `useFrequencyBasedMinification`, addressing the
in-repo TODO in
`packages/flutter_tools/lib/src/web/compiler_config.dart`: "consider
renaming this to be 'positive'. Double negatives are confusing."
(TODO(kevmoo)).

**What changes:** The parameter is now positive:
`useFrequencyBasedMinification` (default `true`). When set to `false`,
the compiler still receives `--no-frequency-based-minification`. The CLI
flag remains `--no-frequency-based-minification`; only the Dart API and
internal naming change.

**Why:** Positive naming improves readability (e.g.
`useFrequencyBasedMinification: false` is clearer than
`noFrequencyBasedMinification: true`). No behavior or CLI contract
change.

**Issues fixed:** None. This addresses an in-repo TODO; an issue is not
required for this trivial refactor per the template.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
N/A — no changes in flutter/tests.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above. (N/A: trivial refactor; addresses in-repo TODO.)
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt]. (Existing tests updated; no new behavior.)
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Author: jhonathanqz

packages/flutter_tools/lib/src/commands/build_web.dart

@@ -223,7 +223,7 @@ class BuildWebCommand extends BuildSubCommand {
           dumpInfo: boolArg('dump-info'),
           minify: minifyJs,
           nativeNullAssertions: boolArg('native-null-assertions'),
-          noFrequencyBasedMinification: boolArg('no-frequency-based-minification'),
+          useFrequencyBasedMinification: !boolArg('no-frequency-based-minification'),
           optimizationLevel: jsOptimizationLevel,
           sourceMaps: sourceMaps,
         ),
@@ -235,7 +235,7 @@ class BuildWebCommand extends BuildSubCommand {
           dumpInfo: boolArg('dump-info'),
           minify: minifyJs,
           nativeNullAssertions: boolArg('native-null-assertions'),
-          noFrequencyBasedMinification: boolArg('no-frequency-based-minification'),
+          useFrequencyBasedMinification: !boolArg('no-frequency-based-minification'),
           optimizationLevel: jsOptimizationLevel,
           sourceMaps: sourceMaps,
           renderer: webRenderer,

packages/flutter_tools/lib/src/web/compiler_config.dart

@@ -59,7 +59,7 @@ class JsCompilerConfig extends WebCompilerConfig {
     this.dumpInfo = false,
     this.nativeNullAssertions = false,
     super.optimizationLevel,
-    this.noFrequencyBasedMinification = false,
+    this.useFrequencyBasedMinification = true,
     super.sourceMaps = true,
     this.minify,
     super.renderer = WebRendererMode.defaultForJs,
@@ -85,9 +85,10 @@ class JsCompilerConfig extends WebCompilerConfig {
   /// Whether native null assertions are enabled.
   final bool nativeNullAssertions;
 
-  // If `--no-frequency-based-minification` should be passed to dart2js
-  // TODO(kevmoo): consider renaming this to be "positive". Double negatives are confusing.
-  final bool noFrequencyBasedMinification;
+  /// Whether to use frequency-based minification in dart2js.
+  ///
+  /// When `false`, passes `--no-frequency-based-minification` to the compiler.
+  final bool useFrequencyBasedMinification;
 
   @override
   CompileTarget get compileTarget => CompileTarget.js;
@@ -101,7 +102,7 @@ class JsCompilerConfig extends WebCompilerConfig {
     if (buildMode == BuildMode.debug) '--enable-asserts',
     '-O${optimizationLevelForBuildMode(buildMode)}',
     if (minify ?? buildMode == BuildMode.release) '--minify' else '--no-minify',
-    if (noFrequencyBasedMinification) '--no-frequency-based-minification',
+    if (!useFrequencyBasedMinification) '--no-frequency-based-minification',
     if (csp) '--csp',
   ];
 
@@ -133,7 +134,7 @@ class JsCompilerConfig extends WebCompilerConfig {
       'csp': csp,
       'dumpInfo': dumpInfo,
       'nativeNullAssertions': nativeNullAssertions,
-      'noFrequencyBasedMinification': noFrequencyBasedMinification,
+      'useFrequencyBasedMinification': useFrequencyBasedMinification,
       'minify': minify,
       WebCompilerConfig.kSourceMapsEnabled: sourceMaps,
     };

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

@@ -1228,7 +1228,7 @@ _flutter.loader.load();
       );
 
       await Dart2JSTarget(
-        const JsCompilerConfig(noFrequencyBasedMinification: true, sourceMaps: false),
+        const JsCompilerConfig(useFrequencyBasedMinification: false, sourceMaps: false),
       ).build(environment);
     }, overrides: <Type, Generator>{ProcessManager: () => processManager}),
   );
@@ -1334,7 +1334,7 @@ _flutter.loader.load();
       JsCompilerConfig(dumpInfo: true),
       JsCompilerConfig(nativeNullAssertions: true),
       JsCompilerConfig(optimizationLevel: 0),
-      JsCompilerConfig(noFrequencyBasedMinification: true),
+      JsCompilerConfig(useFrequencyBasedMinification: false),
       JsCompilerConfig(sourceMaps: false),
       JsCompilerConfig(minify: false),
 
@@ -1344,7 +1344,7 @@ _flutter.loader.load();
         dumpInfo: true,
         nativeNullAssertions: true,
         optimizationLevel: 0,
-        noFrequencyBasedMinification: true,
+        useFrequencyBasedMinification: false,
         sourceMaps: false,
       ),
     ];