[ Tool ] Don't emit artifact downloading messages when --machine is provided (flutter#174301)

Fixes flutter#154119

Author: bkonyi

packages/flutter_tools/lib/executable.dart

@@ -86,9 +86,7 @@ Future<void> main(List<String> args) async {
   final bool muteCommandLogging = (help || doctor) && !veryVerbose;
   final bool verboseHelp = help && verbose;
   final bool daemon = args.contains('daemon');
-  final bool runMachine =
-      (args.contains('--machine') && args.contains('run')) ||
-      (args.contains('--machine') && args.contains('attach'));
+  final bool runMachine = args.contains('--machine');
 
   // Cache.flutterRoot must be set early because other features use it (e.g.
   // enginePath's initializer uses it). This can only work with the real

packages/flutter_tools/test/general.shard/runner/runner_test.dart

@@ -5,6 +5,7 @@
 import 'dart:async';
 
 import 'package:file/memory.dart';
+import 'package:flutter_tools/executable.dart';
 import 'package:flutter_tools/runner.dart' as runner;
 import 'package:flutter_tools/src/artifacts.dart';
 import 'package:flutter_tools/src/base/bot_detector.dart';
@@ -17,6 +18,7 @@ import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/base/process.dart';
 import 'package:flutter_tools/src/base/user_messages.dart';
 import 'package:flutter_tools/src/cache.dart';
+import 'package:flutter_tools/src/commands/devices.dart';
 import 'package:flutter_tools/src/globals.dart' as globals;
 import 'package:flutter_tools/src/reporting/crash_reporting.dart';
 import 'package:flutter_tools/src/runner/flutter_command.dart';
@@ -576,6 +578,47 @@ void main() {
         BotDetector: () => const FakeBotDetector(true),
       },
     );
+
+    testUsingContext(
+      'do not print download messages when --machine is provided',
+      () async {
+        // Regression test for https://github.com/flutter/flutter/issues/154119.
+        final stdio = FakeStdio();
+        await runner.run(
+          <String>['devices', '--machine'],
+          () => <FlutterCommand>[DevicesCommand()],
+          // This flutterVersion disables crash reporting.
+          flutterVersion: '[user-branch]/',
+          shutdownHooks: ShutdownHooks(),
+          overrides: {
+            Logger: () {
+              final loggerFactory = LoggerFactory(
+                outputPreferences: globals.outputPreferences,
+                terminal: globals.terminal,
+                stdio: stdio,
+              );
+              return loggerFactory.createLogger(
+                daemon: false,
+                // This is set to true when --machine is detected as an argument in
+                // executable.dart.
+                machine: true,
+                verbose: false,
+                prefixedErrors: false,
+                windows: globals.platform.isWindows,
+              );
+            },
+          },
+        );
+        expect(stdio.writtenToStdout.join(), isNot(contains('Downloading')));
+        expect(stdio.writtenToStderr.join(), isNot(contains('Downloading')));
+      },
+      overrides: <Type, Generator>{
+        Cache: () => FakeCache(),
+        FileSystem: () => MemoryFileSystem.test(),
+        ProcessManager: () => FakeProcessManager.any(),
+        BotDetector: () => const FakeBotDetector(true),
+      },
+    );
   });
 
   group('unified_analytics', () {
@@ -822,3 +865,16 @@ class _ErrorOnCanRunFakeProcessManager extends Fake implements FakeProcessManage
     return delegate.canRun(executable, workingDirectory: workingDirectory);
   }
 }
+
+class FakeCache extends Fake implements Cache {
+  @override
+  Future<void> lock() async {}
+
+  @override
+  void releaseLock() {}
+
+  @override
+  Future<void> updateAll(Set<DevelopmentArtifact> requiredArtifacts, {bool offline = false}) async {
+    globals.logger.startProgress('Downloading package Foo').stop();
+  }
+}