Skip to content

Commit 6c8df96

Browse files
authored
[flutter_goldens] Remove dead check on null being in a list of non-nullables (flutter#183938)
To complete dart-lang/sdk#57101, we must remove these checks which would be reported by the analyzer. These two lists cannot contain `null`. Work towards dart-lang/sdk#57101 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
1 parent 82d96ef commit 6c8df96

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

packages/flutter_goldens/lib/skia_client.dart

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -177,15 +177,6 @@ class SkiaGoldClient {
177177
'--passfail',
178178
];
179179

180-
if (imgtestInitCommand.contains(null)) {
181-
final buf = StringBuffer()
182-
..writeln('A null argument was provided for Skia Gold imgtest init.')
183-
..writeln('Please confirm the settings of your golden file test.')
184-
..writeln('Arguments provided:');
185-
imgtestInitCommand.forEach(buf.writeln);
186-
throw SkiaException(buf.toString());
187-
}
188-
189180
final io.ProcessResult result = await process.run(imgtestInitCommand);
190181

191182
if (result.exitCode != 0) {
@@ -308,15 +299,6 @@ class SkiaGoldClient {
308299
...getCIArguments(),
309300
];
310301

311-
if (imgtestInitCommand.contains(null)) {
312-
final buf = StringBuffer()
313-
..writeln('A null argument was provided for Skia Gold tryjob init.')
314-
..writeln('Please confirm the settings of your golden file test.')
315-
..writeln('Arguments provided:');
316-
imgtestInitCommand.forEach(buf.writeln);
317-
throw SkiaException(buf.toString());
318-
}
319-
320302
final io.ProcessResult result = await process.run(imgtestInitCommand);
321303

322304
if (result.exitCode != 0) {

0 commit comments

Comments
 (0)