Update some semantics flags updated to use enum (engine, framework, web) (flutter#170696)

issue: flutter#166101,


new Updates :
Add new enum Tristate and CheckedState in  for 7 flags.
For CheckState, it used to use 3 bools (hasCheck, isChecked,
isCheckStateMixed) to represent check states, replace them with a
CheckState enum.
For other 6 flags, each has 2 bools (hasXXState and isXX), replace them
with a Tristate enum.

This will be a breaking changes to the SemanticsFlags class , which was
added in April in flutter#166101 and
flutter#167771 , will write a breaking
change doc for this PR




## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Author: hannah-hyj

engine/src/flutter/lib/ui/semantics.dart

@@ -18,14 +18,15 @@ NativeSemanticsFlags::~NativeSemanticsFlags() {}
 
 void NativeSemanticsFlags::initSemanticsFlags(
     Dart_Handle semantics_flags_handle,
-    bool hasCheckedState,
-    bool isChecked,
-    bool isSelected,
+    int isChecked,
+    int isSelected,
+    int isEnabled,
+    int isToggled,
+    int isExpanded,
+    int isRequired,
+    int isFocused,
     bool isButton,
     bool isTextField,
-    bool isFocused,
-    bool hasEnabledState,
-    bool isEnabled,
     bool isInMutuallyExclusiveGroup,
     bool isHeader,
     bool isObscured,
@@ -34,34 +35,27 @@ void NativeSemanticsFlags::initSemanticsFlags(
     bool isHidden,
     bool isImage,
     bool isLiveRegion,
-    bool hasToggledState,
-    bool isToggled,
     bool hasImplicitScrolling,
     bool isMultiline,
     bool isReadOnly,
     bool isFocusable,
     bool isLink,
     bool isSlider,
-    bool isKeyboardKey,
-    bool isCheckStateMixed,
-    bool hasExpandedState,
-    bool isExpanded,
-    bool hasSelectedState,
-    bool hasRequiredState,
-    bool isRequired) {
+    bool isKeyboardKey) {
   UIDartState::ThrowIfUIOperationsProhibited();
   auto native_semantics_flags = fml::MakeRefCounted<NativeSemanticsFlags>();
   native_semantics_flags->AssociateWithDartWrapper(semantics_flags_handle);
 
   native_semantics_flags->flags_ = SemanticsFlags{
-      .hasCheckedState = hasCheckedState,
-      .isChecked = isChecked,
-      .isSelected = isSelected,
+      .isChecked = static_cast<SemanticsCheckState>(isChecked),
+      .isSelected = static_cast<SemanticsTristate>(isSelected),
+      .isEnabled = static_cast<SemanticsTristate>(isEnabled),
+      .isToggled = static_cast<SemanticsTristate>(isToggled),
+      .isExpanded = static_cast<SemanticsTristate>(isExpanded),
+      .isRequired = static_cast<SemanticsTristate>(isRequired),
+      .isFocused = static_cast<SemanticsTristate>(isFocused),
       .isButton = isButton,
       .isTextField = isTextField,
-      .isFocused = isFocused,
-      .hasEnabledState = hasEnabledState,
-      .isEnabled = isEnabled,
       .isInMutuallyExclusiveGroup = isInMutuallyExclusiveGroup,
       .isHeader = isHeader,
       .isObscured = isObscured,
@@ -70,21 +64,12 @@ void NativeSemanticsFlags::initSemanticsFlags(
       .isHidden = isHidden,
       .isImage = isImage,
       .isLiveRegion = isLiveRegion,
-      .hasToggledState = hasToggledState,
-      .isToggled = isToggled,
       .hasImplicitScrolling = hasImplicitScrolling,
       .isMultiline = isMultiline,
       .isReadOnly = isReadOnly,
-      .isFocusable = isFocusable,
       .isLink = isLink,
       .isSlider = isSlider,
       .isKeyboardKey = isKeyboardKey,
-      .isCheckStateMixed = isCheckStateMixed,
-      .hasExpandedState = hasExpandedState,
-      .isExpanded = isExpanded,
-      .hasSelectedState = hasSelectedState,
-      .hasRequiredState = hasRequiredState,
-      .isRequired = isRequired,
   };
 }
 

engine/src/flutter/lib/ui/semantics/semantics_flags.cc

@@ -10,15 +10,28 @@
 
 namespace flutter {
 
+enum class SemanticsTristate : int32_t {
+  kNone = 0,
+  kTrue = 1,
+  kFalse = 2,
+};
+enum class SemanticsCheckState : int32_t {
+  kNone = 0,
+  kTrue = 1,
+  kFalse = 2,
+  kMixed = 3,
+};
+
 struct SemanticsFlags {
-  bool hasCheckedState = false;
-  bool isChecked = false;
-  bool isSelected = false;
+  SemanticsCheckState isChecked = SemanticsCheckState::kNone;
+  SemanticsTristate isSelected = SemanticsTristate::kNone;
+  SemanticsTristate isEnabled = SemanticsTristate::kNone;
+  SemanticsTristate isToggled = SemanticsTristate::kNone;
+  SemanticsTristate isExpanded = SemanticsTristate::kNone;
+  SemanticsTristate isRequired = SemanticsTristate::kNone;
+  SemanticsTristate isFocused = SemanticsTristate::kNone;
   bool isButton = false;
   bool isTextField = false;
-  bool isFocused = false;
-  bool hasEnabledState = false;
-  bool isEnabled = false;
   bool isInMutuallyExclusiveGroup = false;
   bool isHeader = false;
   bool isObscured = false;
@@ -27,21 +40,12 @@ struct SemanticsFlags {
   bool isHidden = false;
   bool isImage = false;
   bool isLiveRegion = false;
-  bool hasToggledState = false;
-  bool isToggled = false;
   bool hasImplicitScrolling = false;
   bool isMultiline = false;
   bool isReadOnly = false;
-  bool isFocusable = false;
   bool isLink = false;
   bool isSlider = false;
   bool isKeyboardKey = false;
-  bool isCheckStateMixed = false;
-  bool hasExpandedState = false;
-  bool isExpanded = false;
-  bool hasSelectedState = false;
-  bool hasRequiredState = false;
-  bool isRequired = false;
 };
 
 //------------------------------------------------------------------------------
@@ -57,14 +61,15 @@ class NativeSemanticsFlags
   //----------------------------------------------------------------------------
   /// The init method
   static void initSemanticsFlags(Dart_Handle semantics_flags_handle,
-                                 bool hasCheckedState,
-                                 bool isChecked,
-                                 bool isSelected,
+                                 int isChecked,
+                                 int isSelected,
+                                 int isEnabled,
+                                 int isToggled,
+                                 int isExpanded,
+                                 int isRequired,
+                                 int isFocused,
                                  bool isButton,
                                  bool isTextField,
-                                 bool isFocused,
-                                 bool hasEnabledState,
-                                 bool isEnabled,
                                  bool isInMutuallyExclusiveGroup,
                                  bool isHeader,
                                  bool isObscured,
@@ -73,21 +78,13 @@ class NativeSemanticsFlags
                                  bool isHidden,
                                  bool isImage,
                                  bool isLiveRegion,
-                                 bool hasToggledState,
-                                 bool isToggled,
                                  bool hasImplicitScrolling,
                                  bool isMultiline,
                                  bool isReadOnly,
                                  bool isFocusable,
                                  bool isLink,
                                  bool isSlider,
-                                 bool isKeyboardKey,
-                                 bool isCheckStateMixed,
-                                 bool hasExpandedState,
-                                 bool isExpanded,
-                                 bool hasSelectedState,
-                                 bool hasRequiredState,
-                                 bool isRequired);
+                                 bool isKeyboardKey);
 
   //----------------------------------------------------------------------------
   /// Returns the c++ representataion of SemanticsFlags.