Commit 81a8869
committed
fix(telemetry): fix endToolSpan status on success — toolCalls is empty in finally
Root cause: checkAndNotifyCompletion clears this.toolCalls before the
finally block in executeSingleToolCall runs, so the tc lookup always
returns undefined.
Fix: set OK status explicitly in _executeToolCallBody's success path
via safeSetStatus(span, OK), and call endToolSpan() without metadata
in finally (just ends the span, preserves pre-set status from any path).1 parent 155fbd1 commit 81a8869
1 file changed
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1868 | 1868 | | |
1869 | 1869 | | |
1870 | 1870 | | |
1871 | | - | |
1872 | | - | |
1873 | | - | |
1874 | | - | |
1875 | | - | |
1876 | | - | |
| 1871 | + | |
1877 | 1872 | | |
1878 | 1873 | | |
1879 | 1874 | | |
| |||
2170 | 2165 | | |
2171 | 2166 | | |
2172 | 2167 | | |
| 2168 | + | |
2173 | 2169 | | |
2174 | 2170 | | |
2175 | 2171 | | |
| |||
0 commit comments