You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat(triage): make minimal-change an explicit PR review check (#5146)
The triage gatekeeper already nudged toward KISS/simpler solutions across
Stage 1c, 2a, and 3, but never explicitly asked whether a diff stays
minimal — leaving unrelated changes, drive-by refactors, and scope creep
to slip through as a soft, easily-skipped signal.
Make it explicit without adding a hard gate:
- Stage 1c: add a dedicated 'Minimal change' checkpoint and extend the
closing nudge to cover changes beyond the minimal set.
- Stage 1 comment template (EN + ZH): surface unrelated changes / drive-by
refactors to the contributor and suggest splitting them out.
- Stage 3 reflect: add a checklist item on whether every change is needed.
Keeps the existing 'genuine question, not a blocker' tone.
- If we cut 80% of the scope, would the remaining 20% already solve the problem?
84
84
- Could we achieve the same goal by modifying something that already exists, instead of adding something new?
85
85
- Can the complexity live outside the codebase (user config, external tool) instead of inside it?
86
+
-**Minimal change:** is every edit in the diff needed for the stated goal, or does it carry unrelated changes, drive-by refactors, formatting churn, or scope creep that should be split into a separate PR? A focused PR that does one thing is easier to review, revert, and reason about.
86
87
87
-
If you spot a materially simpler path, raise it — not as a blocker, but as a genuine question the contributor should think about before the code review.
88
+
If you spot a materially simpler path, or changes that go beyond the minimal set needed for the stated goal, raise it — not as a blocker, but as a genuine question the contributor should think about before the code review.
88
89
89
90
Implementation-level concerns (over-abstraction, code duplication, "10 lines vs 10 files") belong in Stage 2a code review — you need to see the code for those.
90
91
@@ -99,7 +100,7 @@ Template looks good ✓
99
100
100
101
On direction: <state your honest assessment — aligned and why, or concerns and why>. CHANGELOG <reference if found, or "no direct reference but the area is relevant">.
101
102
102
-
On approach: <state your honest assessment — the scope feels right / feels like it could be much simpler / here's what I'd consider cutting>. <If you see a simpler path, name it: "Have you considered just X? It might cover most of the use case with a fraction of the complexity.">
103
+
On approach: <state your honest assessment — the scope feels right / feels like it could be much simpler / here's what I'd consider cutting>. <If you see a simpler path, name it: "Have you considered just X? It might cover most of the use case with a fraction of the complexity."> <If the diff carries unrelated changes or drive-by refactors, name them and suggest splitting them out.>
103
104
104
105
<Ifpassing:> Moving on to code review. 🔍
105
106
<Ifconcerns:> Flagging these for discussion before diving deeper.
@@ -113,7 +114,7 @@ On approach: <state your honest assessment — the scope feels right / feels lik
0 commit comments