fix: add cache limits to prevent OOM during build/test#4188
Open
xmillogx-cmd wants to merge 1 commit into
Open
fix: add cache limits to prevent OOM during build/test#4188xmillogx-cmd wants to merge 1 commit into
xmillogx-cmd wants to merge 1 commit into
Conversation
1f5cfbe to
6482b04
Compare
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crawlCacheandfileReadCache to prevent unbounded memory growth. Added--max-old-space-size=3072` to critical npm scripts as a safety net.Mapcaches, causing heap usage to spike to ~5.8 GB and crash withFATAL ERROR: JavaScript heap out of memory. TTL expiration was insufficient because tests completed before entries expired.crawlCache.ts(dual limit: entries count + total paths) and ensurefileReadCache.tscorrectly evicts oldest entries onupsert. Verify thatpackage.jsonscripts include the memory flag.Validation
JavaScript heap out of memoryerrors observed.npm test --workspaces --parallelon a large monorepo or the current codebase.top. It should plateau around 1.5GB instead of climbing indefinitely.FATAL ERROR: Ineffective mark-compacts near heap limit.Scope / Risk
Testing Matrix
Testing matrix notes:
npm run teston macOS (Apple Silicon) and Linux (Ubuntu CI environment).npxand containerized runs inherit the samepackage.jsonscripts, so behavior is expected to be identical.Linked Issues / Bugs