docs(daemon): Refresh daemon docs in English#5144
Merged
Merged
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
doudouOUC
force-pushed
the
docs/daemon-english-docs
branch
from
f0d6202 to
e7be6ce
Compare
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
- eventRingSize default: 1024 → 8000 (01-architecture.md) - Restore full 8-step middleware chain in HTTP lifecycle diagram - Hysteresis re-arm condition: <= → < (06-mcp-budget-guardrails.md) - permissionMediator.ts line range: 1-1292 → 1-1198 - FsErrorKind count: 13 → 14 (07-workspace-filesystem.md) - Remove broken links to design/f2-mcp-transport-pool.md
doudouOUC
changed the title
Collaborator
|
Thanks for the PR! Template looks good ✓ On direction: straightforward — the daemon developer docs were added in Chinese by #4412, and the rest of the developer docs are English. This brings them in line. No directional concern. On approach: the scope is large (+2819/-2555 across 26 files) but appropriate for a full translation refresh of a 20-doc section plus meta files and adjacent pages. The PR also tightens source-code reference counts to match current Moving on to code review. 🔍 中文说明感谢贡献！ 模板完整 ✓ 方向：直接对齐——daemon 开发者文档在 #4412 中是中文新增的，周边开发者文档都是英文，统一翻译合理。 方案：范围较大（26 文件 +2819/-2555）但对于完整翻译刷新合理。PR 同时把源码参考数字对齐到当前 main，这是好习惯。抽查发现：文档中的 event type 数量写的是 43，但 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Collaborator
2a. Code ReviewSpot-checked the diff across the index page, architecture doc, event schema, capabilities, session lifecycle, and navigation meta files. The translation is thorough and reads naturally — technical terms (ACP bridge, EventBus, MCP transport pool, mediator policies) are preserved correctly, and relative links between docs are intact. Independent proposal check: for a translation refresh, the only thing I'd do differently is verify the numerical claims against source one more time before merge. As noted in Stage 1, the event count (43 claimed vs 46 actual) and capability count (66 vs 68) are slightly stale on current No critical blockers found. The diff is purely markdown/TS meta files — no runtime code changes, no security surface, no regression risk. Formatting: prettier passes on all changed files. No remaining Chinese text detected ( 2b. Real-Scenario TestingThis is a docs-only PR — no runtime behavior changes. Testing limited to static verification: Source-code count verification:
中文说明2a. 代码审查抽查了 diff 中的索引页、架构文档、event schema、capabilities、session lifecycle 和导航 meta 文件。翻译完整、通顺自然，技术术语（ACP bridge、EventBus、MCP transport pool、mediator policies）保留正确，文档间相对链接完好。 没有发现关键阻塞问题。diff 仅涉及 markdown 和 TS meta 文件，无运行时代码改动。 2b. 测试仅文档 PR，无运行时行为变更。静态验证结果：prettier 通过、无残留中文、无过时标记。 源码数字校验：event type 文档写 43 实际 46，capability 文档写 66 实际 68，conditional 10 正确。建议合并前修正。 — Qwen Code · qwen3.7-max |
Collaborator
|
This is a clean translation PR that does exactly what it says. The daemon developer docs were Chinese-only after #4412; this brings them in line with the rest of the English developer docs. The translation reads naturally, technical terms are preserved, and all formatting checks pass. The only issue is two stale numerical claims: event type count (43 vs 46 actual) and capability tag count (66 vs 68 actual). These are minor — three events and two capabilities were likely added to Approving with that minor caveat. ✅ 中文说明这是一个干净的翻译 PR，完成了它所描述的工作。daemon 开发者文档在 #4412 后仅中文，本次翻译使其与英文开发者文档对齐。翻译通顺，技术术语正确，格式检查通过。 唯一问题是两个过时的数字：event type 数量（文档 43 vs 实际 46）和 capability tag 数量（文档 66 vs 实际 68）。建议在合并前快速修正。 带此小提醒通过 ✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
approved these changes
Jun 15, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
previously approved these changes
Jun 15, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅
Complete and accurate translation of 20 daemon developer docs, navigation labels, and a deprecation notice from Chinese to English. All 192 relative markdown links resolve correctly, no Chinese text remains, technical terminology is consistent, and document structure is preserved.
— qwen3.7-max via Qwen Code /review
DragonnZhang
previously approved these changes
Jun 15, 2026
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Docs-only translation PR: translates 24 daemon developer docs files from Chinese to English. Content is accurate and consistent with the existing codebase terminology. CI green. LGTM ✅ — claude-opus-4-6 via Qwen Code /review
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
doudouOUC
dismissed stale reviews from DragonnZhang and qwen-code-ci-bot
via
95eeb4c
doudouOUC
commented
Jun 15, 2026
doudouOUC
left a comment
doudouOUC
left a comment
Collaborator
Author
There was a problem hiding this comment.
— qwen3.7-max via Qwen Code /review
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Docs-only translation PR (Chinese → English) for 26 daemon developer documentation files. Translation is thorough and consistent with existing codebase terminology.
Existing findings from @doudouOUC (6 inline comments, all on current commit):
- 2 Critical: F2 design doc reference removed from index table; Web UI client removed from architecture diagrams
- 4 Suggestions: Fabricated line ranges in file references; Mermaid diagram missing
trustedparameter; capabilities count off by one (66 vs 67); HTML entities in Mermaid diagram
These findings are valid and should be addressed before merge.
Downgraded from Approve to Comment: CI failing (review-pr) + existing Critical findings need resolution.
— claude-opus-4-6 via Qwen Code /review
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
wenshao
requested changes
Jun 15, 2026
wenshao
left a comment
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
9 files fail prettier --check (table cell padding). Run npx prettier --write docs/developers/daemon/*.md to fix all at once. — qwen3.7-max via Qwen Code /review
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Incremental review at bc5a009f: 3 new commits address previous review feedback (restore F2 design doc reference, restore Web UI client in architecture diagrams, fix fabricated line ranges, fix Mermaid diagram trusted parameter, correct capabilities count, fix HTML entities). Changes span 22 docs files with corrections across the daemon developer documentation set. The previous 6 inline findings should now be resolved (12 stale comments on old commits).
Downgraded from Approve to Comment: CI pending.
— claude-opus-4-6 via Qwen Code /review
doudouOUC
changed the title
Collaborator
|
Qwen Code review did not complete successfully: Qwen review aborted with an API error before posting comments. See workflow logs. |
wenshao
reviewed
Jun 15, 2026
wenshao
left a comment
wenshao
left a comment
Collaborator
There was a problem hiding this comment.
— qwen3.7-max via Qwen Code /review
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Incremental review at 87a258fb058dd4c0e1031697a47ba55522565b23: one new commit addressing PR review feedback. 13 files changed with minor corrections across daemon developer docs (event schema, error taxonomy, quickstart operations, configuration, auth security, SDK client, CLI/TUI adapter, etc.). Changes appear to be editorial refinements based on reviewer comments.
CI failing on review-pr workflow check (not actual tests).
Downgraded from Approve to Comment: CI review-pr check failing.
— claude-opus-4-6 via Qwen Code /review
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
DragonnZhang
left a comment
DragonnZhang
left a comment
Collaborator
There was a problem hiding this comment.
Docs-only translation PR (Chinese → English) for daemon developer documentation. Translation is thorough and aligns with existing codebase terminology. Multiple review rounds have addressed feedback. CI currently pending.
— claude-opus-4-6 via Qwen Code /review
wenshao
approved these changes
Jun 15, 2026
Collaborator
|
Qwen Code review did not complete successfully: Qwen review aborted with an API error before posting comments. See workflow logs. |
Collaborator
|
@qwen-code /triage |
qwen-code-ci-bot
approved these changes
Jun 15, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — clean translation, minor stale counts (43→46 events, 66→68 caps) worth a fix-up before merge. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This follow-up refreshes the daemon developer documentation set in English so the daemon deep-dive pages, navigation labels, quickstart guidance, adapter notes, and operational references match the surrounding developer docs. It also reconciles the translated docs with the current
mainimplementation surface, including the daemon event schema, serve capabilities, startup flags, configuration references, error taxonomy, resync behavior, MCP pool behavior, and web UI wording.Why it's needed
PR #4412 added the daemon-mode developer docs, but the new section was still primarily Chinese while the surrounding developer documentation is English. Keeping this section in English makes the daemon reference easier for contributors to review and keeps navigation, overview pages, and operational guidance in one language. The follow-up source checks and review fixes also reduce the risk that translated prose drifts from the actual daemon implementation.
Reviewer Test Plan
How to verify
Confirm the daemon developer docs, daemon navigation labels, and daemon client adapter notes read naturally in English and no longer contain Chinese text or stale
(English)title suffixes. Confirm the implementation-sensitive reference points line up with source: 43 daemon event types, 66 registered capability tags, 10 conditional capability tags, 25 primaryqwen servestartup flag rows, the complete daemon-host error-kind table, andsession_snapshotin the resync passthrough documentation.Validation run locally:
npx prettier --check docs/developers/_meta.ts docs/developers/daemon/*.md docs/developers/daemon/_meta.ts docs/developers/daemon-client-adapters/tui.md;rg -n "[一-龥]|^# .*\\(English\\)|29 known|six top-level|No OpenTelemetry|已过时" docs/developers/daemon docs/developers/daemon-client-adapters/tui.md docs/developers/_meta.ts;git diff --check origin/main..HEAD; Node checks for daemon event, capability, conditional capability, startup flag, and relative-link counts; andnpm run build && npm run typecheckafter the latest review-fix commit.Evidence (Before & After)
N/A - docs-only change.
Tested on
Environment (optional)
N/A - docs-only change.
Risk & Scope
Linked Issues
Follow-up to #4412.
中文说明
What this PR does
这个 follow-up PR 用英文刷新 daemon 开发者文档集，使 daemon 深度文档、导航标签、quickstart 指引、adapter 说明和运维参考与周边开发者文档保持一致。同时，这次也把翻译后的文档重新对齐当前
main的实现 surface，包括 daemon event schema、serve capabilities、启动参数、配置参考、错误分类、resync 行为、MCP pool 行为以及 web UI 相关表述。Why it's needed
PR #4412 新增了 daemon-mode 开发者文档，但新增章节仍主要是中文，而周边开发者文档是英文。将这组文档统一为英文可以让贡献者更容易阅读和 review，也让导航、总览和运维说明保持同一种语言。后续的源码核对和 review 修复也降低了翻译后文档偏离 daemon 实际实现的风险。
Reviewer Test Plan
How to verify
确认 daemon 开发者文档、daemon 导航标签和 daemon client adapter 说明都使用自然顺畅的英文，并且不再包含中文文本或过时的
(English)标题后缀。确认与实现强相关的参考点仍与源码对齐：43 个 daemon event type、66 个 registered capability tag、10 个 conditional capability tag、25 个主要qwen serve启动参数表行、完整的 daemon-host error-kind 表，以及 resync passthrough 文档中的session_snapshot。本地已运行验证：
npx prettier --check docs/developers/_meta.ts docs/developers/daemon/*.md docs/developers/daemon/_meta.ts docs/developers/daemon-client-adapters/tui.md；rg -n "[一-龥]|^# .*\\(English\\)|29 known|six top-level|No OpenTelemetry|已过时" docs/developers/daemon docs/developers/daemon-client-adapters/tui.md docs/developers/_meta.ts；git diff --check origin/main..HEAD；用于校验 daemon event、capability、conditional capability、启动参数和相对链接数量的 Node 检查；以及最新 review-fix commit 之后的npm run build && npm run typecheck。Evidence (Before & After)
N/A - 仅文档变更。
Tested on
Environment (optional)
N/A - 仅文档变更。
Risk & Scope
Linked Issues
#4412 的 follow-up。