fix(qwik-router): submit() always rejects on abort; Form swallows its own rejection

Author: maiieul

.changeset/submit-rejects-on-abort.md

@@ -0,0 +1,5 @@
+---
+'@qwik.dev/router': patch
+---
+
+`action.submit()`/`run()` now always rejects when the submission aborts (a thrown `error()` or unexpected server error) — previously a `SubmitEvent`-based submission resolved with an empty result, letting failures look like successes. `<Form>` handles the rejection internally and keeps emitting `submitcompleted` with `detail.aborted`.

packages/qwik-router/src/runtime/src/form-component.tsx

@@ -65,7 +65,8 @@ export const Form = <O, I>(
             !reloadDocument
               ? $((evt: SubmitEvent) => {
                   if (!action.submitted) {
-                    return action.submit(evt);
+                    // Swallow our own rejection — submitcompleted is the form's abort channel.
+                    return action.submit(evt).catch(() => {});
                   }
                 })
               : undefined,
@@ -86,7 +87,7 @@ export const Form = <O, I>(
           // Since v2, this fires before the action is executed so it can be prevented
           onSubmit$,
           // action.submit "submitcompleted" event for onSubmitCompleted$ events
-          !reloadDocument ? action.submit : undefined,
+          !reloadDocument ? $((evt: SubmitEvent) => action.submit(evt).catch(() => {})) : undefined,
         ],
         method: 'post',
         ['data-spa-reset']: spaReset ? 'true' : undefined,

packages/qwik-router/src/runtime/src/server-functions.ts

@@ -134,7 +134,6 @@ Action.run() can only be called on the browser, for example when a user clicks a
                 detail: detail,
               })
             );
-            return { status, value: undefined, error: undefined };
           }
           throw aborted;
         }

packages/qwik-router/src/runtime/src/types.ts

@@ -988,9 +988,9 @@ export type ActionStore<RETURN, INPUT, OPTIONAL extends boolean = true, ERROR =
    * action in the server.
    *
    * Resolves with `{ status, value, error }` — expected failures (a returned `fail()` or a failed
-   * validator) come back on `error`. A programmatic invocation rejects when the submission aborts
-   * (a thrown `error()` or an unexpected server error); `<Form>` submissions surface aborts via the
-   * `submitcompleted` event's `detail.aborted` instead.
+   * validator) come back on `error`. REJECTS when the submission aborts (a thrown `error()` or an
+   * unexpected server error). `<Form>` handles this rejection internally and surfaces aborts via
+   * the `submitcompleted` event's `detail.aborted`.
    */
   readonly submit: QRL<
     OPTIONAL extends true