fix(e2e): more robust tests

Author: wmertens

e2e/qwik-e2e/apps/qwikrouter-test/src/routes/(common)/issue2644/data.ts

@@ -1 +1,21 @@
-export const data: string[] = [];
+// Per-session storage so the mpa and spa Playwright describe blocks (and any
+// other parallel workers) don't race on a shared module-level array.
+// The session id is carried in a cookie set by the root action.
+const sessionData = new Map<string, string[]>();
+
+export const SESSION_COOKIE = 'issue2644-session';
+
+export const getSessionData = (sessionId: string | undefined): string[] => {
+  if (!sessionId) {
+    return [];
+  }
+  let data = sessionData.get(sessionId);
+  if (!data) {
+    data = [];
+    sessionData.set(sessionId, data);
+  }
+  return data;
+};
+
+export const createSessionId = () =>
+  `s-${Date.now().toString(36)}-${Math.random().toString(36).slice(2, 10)}`;

e2e/qwik-e2e/apps/qwikrouter-test/src/routes/(common)/issue2644/index.tsx

@@ -1,12 +1,17 @@
 import { component$ } from '@qwik.dev/core';
 import { Form, routeAction$ } from '@qwik.dev/router';
-import { data } from './data';
+import { SESSION_COOKIE, createSessionId, getSessionData } from './data';
 
 export const useRootAction = routeAction$(
-  (form, { redirect }) => {
-    const name = form.name as string;
+  (form, { redirect, cookie }) => {
+    let sessionId = cookie.get(SESSION_COOKIE)?.value;
+    if (!sessionId) {
+      sessionId = createSessionId();
+      cookie.set(SESSION_COOKIE, sessionId, { path: '/' });
+    }
+    const data = getSessionData(sessionId);
     data.length = 0;
-    data.push(name);
+    data.push(form.name as string);
     throw redirect(303, '/qwikrouter-test/issue2644/other/');
   },
   {

e2e/qwik-e2e/apps/qwikrouter-test/src/routes/(common)/issue2644/other/index.tsx

@@ -1,12 +1,13 @@
 import { Form, routeAction$, routeLoader$ } from '@qwik.dev/router';
 import { component$ } from '@qwik.dev/core';
-import { data } from '../data';
+import { SESSION_COOKIE, getSessionData } from '../data';
 
-export const useGetData = routeLoader$(() => {
-  return data;
+export const useGetData = routeLoader$(({ cookie }) => {
+  return getSessionData(cookie.get(SESSION_COOKIE)?.value);
 });
 
-export const useOtherAction = routeAction$((form) => {
+export const useOtherAction = routeAction$((form, { cookie }) => {
+  const data = getSessionData(cookie.get(SESSION_COOKIE)?.value);
   const name = form.name as string;
   data.push(name);
   return { success: true };

e2e/qwik-e2e/tests/starter-partytown.e2e.ts

@@ -11,7 +11,9 @@ test('rendered', async ({ page }) => {
 
   const state = page.locator('#state');
 
-  await expect(state).toHaveText('finished');
+  // Partytown spins up a web worker to run the simulated async work; under parallel
+  // test load the worker init can take well over the default 3s expect timeout.
+  await expect(state).toHaveText('finished', { timeout: 15000 });
 });
 
 test('update text', async ({ page }) => {