fix(router): don't crash Vite dev when src/entry.ssr is missing#8601
Open
maiieul wants to merge 1 commit intoQwikDev:build/v2from
Open
fix(router): don't crash Vite dev when src/entry.ssr is missing#8601maiieul wants to merge 1 commit intoQwikDev:build/v2from
maiieul wants to merge 1 commit intoQwikDev:build/v2from
Conversation
The dev middleware called ssrLoadModule('src/entry.ssr') unconditionally,
so Vite hosts that embed the qwikRouter plugin without an entry.ssr
(Storybook, component test runners, etc.) crashed the dev server with an
unhandled rejection. Wrap the load and fall through to next() instead.
🦋 Changeset detectedLatest commit: f65af38 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
The dev middleware in
qwik-routercallsserver.ssrLoadModule('src/entry.ssr')unconditionally. When the qwikRouter Vite plugin is embedded in a host that doesn't ship anentry.ssr(Storybook, component test runners, etc.), the rejected promise becomes an unhandled rejection and crashes the dev server. Wrapping the load lets those hosts fall through tonext()instead.Reproduces today on
@qwik.dev/router@2.0.0-beta.34when running Storybook over a Qwik library withqwikRouter()in the Vite config — workaround isqwikRouter({ devSsrServer: false }).