fix(core): hide node:async_hooks import from non-Qwik bundlers#8602
Draft
maiieul wants to merge 1 commit intoQwikDev:build/v2from
Draft
fix(core): hide node:async_hooks import from non-Qwik bundlers#8602maiieul wants to merge 1 commit intoQwikDev:build/v2from
maiieul wants to merge 1 commit intoQwikDev:build/v2from
Conversation
use-locale.ts does import('node:async_hooks') inside an if (isServer)
branch to set up AsyncLocalStorage. Consumers that bundle @qwik.dev/core
for the browser without the Qwik Vite plugin (e.g. Cypress's
webpack-preprocessor) can't tree-shake the dead branch and fail at build
time with UnhandledSchemeError.
Build the dynamic-import target at runtime so the literal isn't
preserved through Rollup's constant folding, and add /* webpackIgnore */
+ /* @vite-ignore */ comments to cover consumer bundlers.
🦋 Changeset detectedLatest commit: 8302adc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
`packages/qwik/src/core/use/use-locale.ts` does `import('node:async_hooks')` inside an `if (isServer)` branch (added in #9116 — `bdc690ddf` feat(core): use AsyncLocalStorage for locale) to set up `AsyncLocalStorage` server-side.
The `isServer` flag is a runtime check (`!isBrowser` from `@qwik.dev/core/build`), not a bundler define. Consumers bundling `@qwik.dev/core` for the browser without the Qwik Vite plugin can't tree-shake this branch and fail at build time:
```
Module build failed: UnhandledSchemeError: Reading from "node:async_hooks" is not handled by plugins (Unhandled scheme).
```
I hit this with Cypress's default webpack-preprocessor in a Qwik 2 monorepo migration. Any spec file whose import graph touches `@qwik.dev/core` blows up. Same class of issue would hit raw webpack/esbuild/Parcel setups that don't run the Qwik optimizer.
Fix