Skip to content

fix(testing): use isBrowser check in leftover files#8607

Open
saboooor wants to merge 1 commit intoQwikDev:fix-preloader-isBrowser-variablefrom
saboooor:fix-preloader-isBrowser-variable
Open

fix(testing): use isBrowser check in leftover files#8607
saboooor wants to merge 1 commit intoQwikDev:fix-preloader-isBrowser-variablefrom
saboooor:fix-preloader-isBrowser-variable

Conversation

@saboooor
Copy link
Copy Markdown
Contributor

@saboooor saboooor commented May 2, 2026

What is it?

  • Bug

Description

adding on to #8584 fixing leftover code :)

Checklist

@saboooor saboooor requested a review from a team as a code owner May 2, 2026 18:48
Copilot AI review requested due to automatic review settings May 2, 2026 18:48
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

⚠️ No Changeset found

Latest commit: 5947965

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the testing-related cleanup from #8584 by removing ad-hoc import.meta.env.TEST environment detection and standardizing on isBrowser from @qwik.dev/core/build in remaining internal modules.

Changes:

  • Switch scheduleEffects() to use imported isBrowser instead of a test-only isServerPlatform()/isServer fallback.
  • Switch preloader bundle-graph to use imported isBrowser and remove isServerPlatform/isServer imports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/qwik/src/core/reactive-primitives/utils.ts Uses isBrowser from @qwik.dev/core/build to gate client-only vnode diff / node-prop payload behavior.
packages/qwik/src/core/preloader/bundle-graph.ts Uses isBrowser from @qwik.dev/core/build for browser-only preloader initialization and removes test-only environment branching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 5947965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants