fix(testing): use isBrowser check in leftover files#8607
fix(testing): use isBrowser check in leftover files#8607saboooor wants to merge 1 commit intoQwikDev:fix-preloader-isBrowser-variablefrom
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR continues the testing-related cleanup from #8584 by removing ad-hoc import.meta.env.TEST environment detection and standardizing on isBrowser from @qwik.dev/core/build in remaining internal modules.
Changes:
- Switch
scheduleEffects()to use importedisBrowserinstead of a test-onlyisServerPlatform()/isServerfallback. - Switch preloader
bundle-graphto use importedisBrowserand removeisServerPlatform/isServerimports.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/qwik/src/core/reactive-primitives/utils.ts | Uses isBrowser from @qwik.dev/core/build to gate client-only vnode diff / node-prop payload behavior. |
| packages/qwik/src/core/preloader/bundle-graph.ts | Uses isBrowser from @qwik.dev/core/build for browser-only preloader initialization and removes test-only environment branching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
What is it?
Description
adding on to #8584 fixing leftover code :)
Checklist