fix(core): allow duplicate qwik via shared singletons#8609
Open
fix(core): allow duplicate qwik via shared singletons#8609
Conversation
🦋 Changeset detectedLatest commit: 5d43200 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
There was a problem hiding this comment.
Pull request overview
This PR refactors selected mutable runtime state into a version-aware global singleton registry so same-version Qwik copies can share state, primarily to support externalized third-party Qwik libraries on the server without tripping duplicate-runtime issues.
Changes:
- Added a new
shared/singletonsregistry onglobalThis.__qwik__and moved several runtime registries/state holders to use it. - Updated server/testing symbol resolution and build-time allowlists so the new singleton/version plumbing can be imported in server/optimizer builds.
- Added/updated tests and a changeset describing the shared-singleton behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/submodule-server.ts | Allows core/version imports in the server submodule build. |
| scripts/submodule-optimizer.ts | Allows core/version imports in the optimizer submodule build. |
| packages/qwik/src/testing/platform.ts | Switches test symbol lookup to the shared singleton registry. |
| packages/qwik/src/server/qwik-copy.ts | Re-exports the singleton accessor for server runtime code. |
| packages/qwik/src/server/platform.unit.ts | Updates server platform tests to use _regSymbol/new global state. |
| packages/qwik/src/server/platform.ts | Switches server symbol lookup/chunk mapping checks to shared singletons. |
| packages/qwik/src/core/use/use-locale.ts | Moves locale and async-local storage handles into singleton-backed state. |
| packages/qwik/src/core/shared/singletons.ts | Introduces the new global singleton registry and duplicate-version check. |
| packages/qwik/src/core/shared/serdes/inflate.ts | Moves deserialization loading state into the singleton registry. |
| packages/qwik/src/core/shared/serdes/deser-proxy.ts | Moves deserializer proxy cache into the singleton registry. |
| packages/qwik/src/core/shared/serdes/allocate.ts | Moves deserialization resolver/store-target maps into the singleton registry. |
| packages/qwik/src/core/shared/qrl/qrl.ts | Registers inline QRL symbols via the singleton-backed registry. |
| packages/qwik/src/core/shared/qrl/qrl-class.ts | Reads the singleton-backed deserialization loading state. |
| packages/qwik/src/core/index.ts | Replaces inline duplicate-import guard with singleton module side effect import. |
| .changeset/shared-singletons-global.md | Records the patch release note for shared global singletons. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+35
| if (isServer) { | ||
| // We can only have 1 Qwik version | ||
| const existing = QWIK.version; | ||
| if (existing) { | ||
| if (existing !== version) { | ||
| // Server allows only one Qwik version per process; same-version coexistence is fine | ||
| // and gets to share the singleton state. | ||
| qError(QError.duplicateQwik, [existing, version]); | ||
| } | ||
| } else { | ||
| QWIK.version = version; | ||
| } | ||
| singletons = QWIK.singletons ||= {}; | ||
| } else { | ||
| // On the client, we can have multiple Qwik versions coexisting, but they don't share state. | ||
| singletons = QWIK[version] ||= {}; | ||
| } |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Member
Author
|
hmm _captures is also a singleton, we need to change it to a holder object |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.