Skip to content

refactor(eslint): modernize plugin deps and rule typing#8621

Open
JerryWu1234 wants to merge 2 commits into
QwikDev:build/v2from
JerryWu1234:eslint_qwik
Open

refactor(eslint): modernize plugin deps and rule typing#8621
JerryWu1234 wants to merge 2 commits into
QwikDev:build/v2from
JerryWu1234:eslint_qwik

Conversation

@JerryWu1234
Copy link
Copy Markdown
Contributor

@JerryWu1234 JerryWu1234 commented May 11, 2026

  • Bump versions of @typescript-eslint/utils, @typescript-eslint/rule-tester, and related packages to 8.59.2 in pnpm-lock.yaml and package.json.
  • Refactor eslint-plugin-qwik rules to utilize utility functions for JSX attribute checks and improve code readability.
  • Remove redundant code and enhance type safety in various rule implementations.
  • Ensure consistent handling of JSX attributes across rules.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner May 11, 2026 01:20
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: 061058d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 11, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8621

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8621

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8621

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8621

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8621

commit: 061058d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 061058d

- Bump versions of @typescript-eslint/utils, @typescript-eslint/rule-tester, and related packages to 8.59.2 in pnpm-lock.yaml and package.json.
- Refactor eslint-plugin-qwik rules to utilize utility functions for JSX attribute checks and improve code readability.
- Remove redundant code and enhance type safety in various rule implementations.
- Ensure consistent handling of JSX attributes across rules.
@JerryWu1234 JerryWu1234 self-assigned this May 12, 2026
@JerryWu1234 JerryWu1234 requested review from GregOnNet and wmertens and removed request for GregOnNet May 13, 2026 02:57
@JerryWu1234 JerryWu1234 added the DX Developer Experience related issue label May 14, 2026
@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Developer Experience related issue

Projects

Status: Waiting For Review

Development

Successfully merging this pull request may close these issues.

1 participant